ac-symbol-documentation fails silently in Emacs HEAD => no help popup

[purcell]

Looks like describe-function-1 now raises an error if current-buffer is not in help-mode, so ac-symbol-documentation fails to gather the info needed for the help popup.

I've looked at the help.el and help-mode.el code, but haven't figured out how to work around this problem.

[purcell]

Here's a fix which works well for me:

diff --git a/auto-complete.el b/auto-complete.el
index b78bcc3..4fa2b71 100644
--- a/auto-complete.el
+++ b/auto-complete.el
@@ -1784,8 +1784,7 @@ completion menu. This workaround stops that annoying behavior."
          ((fboundp symbol)
           ;; import help-xref-following
           (require 'help-mode)
-          (let ((help-xref-following t))
-            (describe-function-1 symbol))
+          (describe-function-1 symbol)
           (buffer-string))
          ((boundp symbol)
           (let ((file-name  (ac-symbol-file symbol 'defvar)))

[purcell]

For your convenience, I've bundled this fix up as a pull request (#51), so I'll close this issue.