Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2-4-2-title #18

Closed
WilcoFiers opened this issue Oct 25, 2016 · 6 comments
Closed

SC2-4-2-title #18

WilcoFiers opened this issue Oct 25, 2016 · 6 comments
Assignees

Comments

@WilcoFiers
Copy link
Member

This rule should be updated before we can finalize it:
https://github.com/auto-wcag/auto-wcag/blob/master/_drafts/SC2-4-2-title.md

Leave any comments in this issue.

@WilcoFiers
Copy link
Member Author

Review for this week's meeting. Couple of points here:

Selector:

  • This should probably select the document root. The title may not be contained within the head, and it can still work. We are not writing parser rules :)

Step 2:

  • I don't think duplicate titles are a WCAG violation. At most it could be that some AT use the first and others the last? But I'm not even sure that's the case. We should do the research on this before we decide if we want to keep this in.

Step 3:
I don't think filenames work here. You could have a title like: "Download logo.jpg" Which I'd say can be a valid title, and hard to distinguish from a filename. I do think that having the filename of the current document, can be a violation, like "home.html". That's also only true if it has an extension, so "home" could be the file name.

Step 4:

  • The table format is broken.
  • Change "does the title identify" to "does the title describe"

@YetAnotherEye
Copy link

Background:
Formatting of assumptions headline needed (they are included in Background)

Step 2: there is ONE title
https://www.w3.org/TR/WCAG20-TECHS/H25.html: "the (mandatory) title element, which only appears once in a document"
https://www.w3.org/TR/html5/document-metadata.html#the-title-element: "There must be no more than one title element per document."

@WilcoFiers
Copy link
Member Author

Hey @kensgists @gianwild @EmmaJP. Any update on this?

@EmmaJP
Copy link
Collaborator

EmmaJP commented Jan 11, 2018

Is there a missing > on the element in the description?

I believe "Test Properties" is covered by the information at the top of the file and no longer a headed table within it.

I can't remember what was decided about heading levels, but looking at the current rule template and recent rules I've been involved with, it looks like Description, Background, Assumptions, and Test Procedure are all the same level heading.

Agree that the selector should any <title> elements within the whole document, not only the element. We should not be testing for well formed HTML. However, the issue over more than one <title> element in an HTML file is interesting. Could a duplicate make a screen reader read the wrong information? With things becoming more componentised, perhaps this is something a tool should check.

Agree Step 3 is unnecessary when a manual/AI check is the next step. The most Step 3 could do is pull out a warning, and the next step is still needed either way.

Current rule template has the Outcome options separate to the Procedure. And also requires implementation tests.

@WilcoFiers
Copy link
Member Author

@EmmaJP @kensgists Please post an updated version of the rule's text in this issue. We can work on it from their.

@jeeyyy
Copy link
Collaborator

jeeyyy commented Apr 11, 2018

We have re-authored, available in PR - #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants