New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SC2-4-6-descriptive-headings #70
Comments
Are you saying here that every text that has one of these properties should be considered a heading? If so, I'm not sure that's true. It also begs the question, larger / bolder than what? |
Agree, we need more specific information on what is considered a heading. We have reused the assumption from an existing draft, https://github.com/auto-wcag/auto-wcag/blob/master/_drafts/SC1-3-1-p-as-heading.md |
This should also include all content marked as a heading element. Possibly also things like table or image captions. Determining what other text could be considered a heading is a lot less clear cut and can easily include things not intended to be a heading. I suspect that would need a person to determine. Would 1.3.1 cover it? |
Made some changes in the Applicability and Assumptions for the testrule. |
Added test cases. |
After the meeting today we changed the applicability to not test for the definition of headers, we will leave that up to a different rule. (possibly in 1.3.1 or in a rule group with this rule). We added assumptions that reflect this and also restructured the test cases to reflect this. We also added an aria and image test case. |
We might need to include "that is [visible on the page][] or [exposed to assistive technologies][]" in the applicability, and if we include that we need to add some additional test cases. |
Closes issue: #70 ## Guidance for the PR (pull request) creator **When creating PR:** - [x] Make sure you requesting to **pull a issue/feature/bugfix branch** (right side) to the master branch (left side). **After creating PR:** - [x] Add yourself (and co-authors) as "Assignees" for PR - [x] Add label to indicate if it's a `Rule`, `Definition` or `Chore` (more to the administrative side) - [x] Add relevant project (e.g. "Q3 2018 Status") to PR - [x] OPTIONAL: If you want anyone in particular to review your pull request, assign them as "Reviewers". - [x] Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment) # How to Review And Approve - Go to the “Files changed” tab - Here you will have the option to leave comments on different lines. - Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
name: Descriptive headings
description: |
This rule checks that headings describe the topic or purpose of the content.
success_criterion:
test aspects:
authors:
Test procedure
Applicability
The rule applies to any element with the the semantic role of
heading
.Note: The WCAG 2.0 success criterion 2.4.6 applies to all headings.
Note: Heading content defines the header of a section (whether explicitly marked up using sectioning content elements, or implied by the heading content itself).
Expectation
Each target element describes the topic or purpose of the subsequent content.
Note: Headings do not need to be lengthy. A word, or even a single character, may suffice.
Assumptions
Accessibility Support
There are no major accessibility support issues known for this rule.
Background
Test Cases
Passed
Failed
Inapplicable
The text was updated successfully, but these errors were encountered: