FINAL: SC3-1-1-html-has-lang #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeeyyy
commented
Apr 27, 2018
jeeyyy
commented
- Rule based on draft - Draft: SC-3-1-1-html-has-lang #85
Brynanders
reviewed
Apr 30, 2018
kasperisager
reviewed
May 3, 2018
_rules/SC3-1-1-html-has-lang.md
Outdated
| @@ -25,13 +25,15 @@ The root element of the page, if it is an `html` element. | |||
|
|
|||
| The test target has a `lang` or `xml:lang` attribute. | |||
|
|
|||
| **Note**: HTML 5 recommends using `lang` instead of `xml:lang`. This is not known to impact accessibility, which is why use of both is permitted by this rule. | |||
There was a problem hiding this comment.
"HTML 5" should be "HTML5".
Brynanders
previously approved these changes
May 3, 2018
kasperisager
previously approved these changes
May 3, 2018
Brynanders
previously approved these changes
May 3, 2018
- Added test cases for empty lang / xml:lang attributes.
- added passed test cases
Brynanders
previously approved these changes
May 7, 2018
kasperisager
previously approved these changes
May 9, 2018
annethyme
approved these changes
May 15, 2018
_rules/SC3-1-1-html-has-lang.md
Outdated
|
|
||
| ### Expectation | ||
|
|
||
| The test target has a `lang` or `xml:lang` attribute. |
There was a problem hiding this comment.
Add non-empty here like in the description:
"The test target has a [non-empty][] lang or xml:lang attribute."
| ```html | ||
| <html xml:lang="en" lang=""> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I suggest adding a passed test case with a non-valid value too, to make clear that we don't test the validity of the values in this rule, e.g.:
<html lang="xyz"><html xml:lang="xyz">
annethyme
previously requested changes
May 15, 2018
WilcoFiers
previously requested changes
May 15, 2018
_rules/SC3-1-1-html-has-lang.md
Outdated
| @@ -0,0 +1,94 @@ | |||
| --- | |||
| name: Existence of HTML Lang attribute | |||
There was a problem hiding this comment.
Why not "HTML has lang attribute"?
_rules/SC3-1-1-html-has-lang.md
Outdated
|
|
||
| ### Expectation | ||
|
|
||
| The test target has a `lang` or `xml:lang` attribute. |
|
Changes done. Review again. |
kasperisager
approved these changes
May 22, 2018
jeeyyy
dismissed stale reviews from WilcoFiers and annethyme
Changes implemented. Review again.
WilcoFiers
approved these changes
Jun 4, 2018
jeeyyy
moved this from Final (Needs Review)
to Auto-Wcag (Pre Publish Review)
in Rules Progress Overview
annethyme
moved this from Auto-Wcag (Pre Publish Review)
to Final (Needs Review)
in Rules Progress Overview
ShadowBB
approved these changes
Jun 15, 2018
editorial update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.