FINAL: SC2-4-2-title #116
FINAL: SC2-4-2-title #116
Conversation
|
+jen as reviewer |
There was a problem hiding this comment.
The “non-empty text” link, links to a “404 page not-found”
Check if you want the changes to other files unrelated to this rule (especially the one on SC 3.1.1) be part of this pull request. I don’t have any issues with that, but I’m not sure what is the correct procedure.
| <iframe src="../test-assets/sc2-4-2-title-page-without-title.html"></iframe> | ||
| </html> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I would add a test case where there is no title in the head but only in the body.
There was a problem hiding this comment.
Added test case. Please review again.
There was a problem hiding this comment.
The test case that @JenniferChadwick mentioned would be a good addition.
jeeyyy
dismissed stale reviews from JenniferChadwick, ShadowBB, and carlosapaduarte
via
3f8757c
|
@ShadowBB @kasperisager @WilcoFiers @cpandhi @JenniferChadwick @carlosapaduarte |
_rules/SC2-4-2-title.md
Outdated
|
|
||
| ```html | ||
| <html> | ||
| <title> <!-- this page has an empty title --> </title> |
There was a problem hiding this comment.
We need another test case where the first title is empty and the second isn't.
|
Should the rule ID be page-has-title? |
jeeyyy
dismissed stale reviews from JenniferChadwick and kasperisager
via
1574efa
|
Have made necessary amends. Please review again. |
| </body> | ||
| </html> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This test will currently fail the rule, not pass:
The first title element contains non-empty text.
There was a problem hiding this comment.
@kasperisager - Good spot. Amended.
There was a problem hiding this comment.
Thanks, guys. Approving.
annethyme
moved this from Completed
to Auto-Wcag (Pre Publish Review)
in Rules Progress Overview
annethyme
moved this from Auto-Wcag (Pre Publish Review)
to Completed
in Rules Progress Overview
fixes: