New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New draft accesskey rule #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we exclude known accesskey combinations (like ALT+Q to quit, ALT+F to open the file menu etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its ok for me.
Remaining gianwild comment about accesskey combinations, I think that it does not affect this rule, because the accesskey combination is controled by the browser:
The rule is about the uniqueness of the accesskey values in a page, rather than whether or not they are sensible values. |
We need to add tests to this as well. |
@gianwild Merging this into draft, we'll open an issue to discuss your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says on the tin.
Issue raised for adding tests ... #58 |
I think we should make sure that people use this only for web applications, not standard web sites. It's a bit like role=menu - only makes sense on a complex web app not a standard web site. |
@gianwild I think it's OK for either, as this rule about the uniqueness of the attribute value rather than how suitably it has been applied. That would be a different test, if there is need for one. |
Thanks @EmmaJP |
Based on the work in issue #43.