Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New draft accesskey rule #53

Merged
merged 1 commit into from Nov 16, 2017
Merged

New draft accesskey rule #53

merged 1 commit into from Nov 16, 2017

Conversation

WilcoFiers
Copy link
Member

Based on the work in issue #43.

Copy link
Collaborator

@gianwild gianwild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we exclude known accesskey combinations (like ALT+Q to quit, ALT+F to open the file menu etc)?

Copy link
Collaborator

@josehilera josehilera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok for me.
Remaining gianwild comment about accesskey combinations, I think that it does not affect this rule, because the accesskey combination is controled by the browser:

@EmmaJP
Copy link
Collaborator

EmmaJP commented Nov 16, 2017

The rule is about the uniqueness of the accesskey values in a page, rather than whether or not they are sensible values.

@WilcoFiers
Copy link
Member Author

We need to add tests to this as well.

@WilcoFiers
Copy link
Member Author

@gianwild Merging this into draft, we'll open an issue to discuss your comment.

@WilcoFiers WilcoFiers merged commit 17ae630 into master Nov 16, 2017
@WilcoFiers WilcoFiers mentioned this pull request Nov 16, 2017
Copy link
Collaborator

@kensgists kensgists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin.

@EmmaJP
Copy link
Collaborator

EmmaJP commented Nov 16, 2017

Issue raised for adding tests ... #58

@WilcoFiers WilcoFiers mentioned this pull request Nov 16, 2017
@gianwild
Copy link
Collaborator

I think we should make sure that people use this only for web applications, not standard web sites. It's a bit like role=menu - only makes sense on a complex web app not a standard web site.
And I always thought accesskeys were ALT + a character - not CTRL. Has that changed?

@EmmaJP
Copy link
Collaborator

EmmaJP commented Jan 22, 2018

@gianwild I think it's OK for either, as this rule about the uniqueness of the attribute value rather than how suitably it has been applied. That would be a different test, if there is need for one.

@gianwild
Copy link
Collaborator

Thanks @EmmaJP

@jeeyyy jeeyyy deleted the SC4-1-1-accesskey-revised branch August 30, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants