Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: SC-3-1-1-html-has-lang #85

Merged
merged 5 commits into from Apr 27, 2018
Merged

Draft: SC-3-1-1-html-has-lang #85

merged 5 commits into from Apr 27, 2018

Conversation

jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Apr 9, 2018

@jeeyyy jeeyyy requested a review from WilcoFiers April 9, 2018 12:03
@jeeyyy jeeyyy mentioned this pull request Apr 9, 2018
kensgists
kensgists previously approved these changes Apr 12, 2018
Copy link
Collaborator

@kensgists kensgists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good...

@jeeyyy jeeyyy changed the title Rule: SC-3-1-1-html-has-lang Draft: SC-3-1-1-html-has-lang Apr 16, 2018
@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Apr 16, 2018

@kensgists @2biazdk @jribbens @rdeltour @WilcoFiers @annethyme @nitedog @skotkjerra @Brynanders
Could do with some approvals/ reviews for this one.

WilcoFiers
WilcoFiers previously approved these changes Apr 16, 2018
---
name: SC3-1-1-html-has-lang

description:
Copy link
Member

@WilcoFiers WilcoFiers Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be description: |

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the | pipe character. You need it to indicate multiline text in YAML. I don't think this is valid YAML.


### Expectation

- The element has a `lang` or `xml:lang` attribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be a list, and should say "The test target has ..."


### Applicability

The root node of the page, if it is an `html` element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as this: #80 (comment)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, changed to root element.

@jeeyyy jeeyyy dismissed stale reviews from WilcoFiers and kensgists via adb00b2 April 16, 2018 11:32
@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Apr 16, 2018

@WilcoFiers @kasperisager
New commits in place, kindly review.

### Expectation

The test target has a `lang` or `xml:lang` attribute.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think xml:lang should only count as a pass if this is an XHTML document - i.e. one served with a MIME type of application/xhtml+xml, application/xml or text/xml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jribbens To the best of my knowledge assistive technologies don't care about the MIME type of a page. Is your concern regarding accessibility support, or is it a standards question?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, both - if it's HTML then according to the specification having only xml:lang is the same as not having the language identified at all, and I was under the impression that assistive technologies ignore xml:lang anyway.

WilcoFiers
WilcoFiers previously approved these changes Apr 16, 2018
---
name: SC3-1-1-html-has-lang

description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the | pipe character. You need it to indicate multiline text in YAML. I don't think this is valid YAML.

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Apr 17, 2018

@WilcoFiers - done, plz approve


### Expectation

The test target has a `lang` or `xml:lang` attribute.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note:

Note: HTML 5 recommends using lang instead of xml:lang. This is not known to impact accessibility, which is why use of both is permitted by this rule.


## Accessibility support

There are no major accessibility support issues known for this rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are known combinations of a popular operating system with browsers and assistive technologies that do not support the lang and xml:lang attributes.

@jeeyyy jeeyyy merged commit c29ea9d into master Apr 27, 2018
@jeeyyy jeeyyy deleted the SC3-1-1-html-has-lang branch April 27, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants