New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: SC-3-1-1-html-has-lang #85
Conversation
jeeyyy
commented
Apr 9, 2018
- Added rule
- Added test cases
- Close issue - SC3-1-1-html-has-lang #75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good...
@kensgists @2biazdk @jribbens @rdeltour @WilcoFiers @annethyme @nitedog @skotkjerra @Brynanders |
_drafts/SC3-1-1-html-has-lang.md
Outdated
--- | ||
name: SC3-1-1-html-has-lang | ||
|
||
description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems correct already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's missing the |
pipe character. You need it to indicate multiline text in YAML. I don't think this is valid YAML.
_drafts/SC3-1-1-html-has-lang.md
Outdated
|
||
### Expectation | ||
|
||
- The element has a `lang` or `xml:lang` attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be a list, and should say "The test target has ..."
_drafts/SC3-1-1-html-has-lang.md
Outdated
|
||
### Applicability | ||
|
||
The root node of the page, if it is an `html` element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as this: #80 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, changed to root element.
@WilcoFiers @kasperisager |
### Expectation | ||
|
||
The test target has a `lang` or `xml:lang` attribute. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think xml:lang
should only count as a pass if this is an XHTML document - i.e. one served with a MIME type of application/xhtml+xml, application/xml or text/xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jribbens To the best of my knowledge assistive technologies don't care about the MIME type of a page. Is your concern regarding accessibility support, or is it a standards question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, both - if it's HTML then according to the specification having only xml:lang
is the same as not having the language identified at all, and I was under the impression that assistive technologies ignore xml:lang
anyway.
_drafts/SC3-1-1-html-has-lang.md
Outdated
--- | ||
name: SC3-1-1-html-has-lang | ||
|
||
description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's missing the |
pipe character. You need it to indicate multiline text in YAML. I don't think this is valid YAML.
@WilcoFiers - done, plz approve |
|
||
### Expectation | ||
|
||
The test target has a `lang` or `xml:lang` attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note:
Note: HTML 5 recommends using
lang
instead ofxml:lang
. This is not known to impact accessibility, which is why use of both is permitted by this rule.
|
||
## Accessibility support | ||
|
||
There are no major accessibility support issues known for this rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are known combinations of a popular operating system with browsers and assistive technologies that do not support the
lang
andxml:lang
attributes.