Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to key out of suggestions list #51

Open
jaronbarends opened this issue Jun 21, 2017 · 0 comments
Open

Be able to key out of suggestions list #51

jaronbarends opened this issue Jun 21, 2017 · 0 comments

Comments

@jaronbarends
Copy link

jaronbarends commented Jun 21, 2017

(I have added pull request #50 for this)

Scenario:

pull request in issue #46 is merged
List of suggestions is open
User navigates the list with up/down arrow keys
User reaches the first (going up) or last (going down) item the list
Now the user can not "leave" the list to be able to submit the text in the search field with [enter]

My pull request makes the active item not wrap around, but removes the active state after the first / last item is passed. (Hitting the up/down key one more time then starts a new sequence, so the order will become 1st - 2nd - 3rd - last - none - 1st - 2nd...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant