Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a new cold-ammonia model? #2

Open
jpinedaf opened this issue Oct 1, 2019 · 1 comment
Open

How to add a new cold-ammonia model? #2

jpinedaf opened this issue Oct 1, 2019 · 1 comment

Comments

@jpinedaf
Copy link

jpinedaf commented Oct 1, 2019

I want to add the cold-ammonia model. The implementation of the model is simply

    dT0 = 41.18 # Energy difference between (2,2) and (1,1) in K
    trot = tkin * (1 + (tkin/dT0)*np.log(1 + 0.6*np.exp(-15.7/tkin)))**-1
    return ammonia(xarr, trot=trot, **kwargs)

I guess a new function AmmoniaRunner_cold() should be created, which looks almost the same as AmmoniaRunner_cold(). Anything else?

@autocorr
Copy link
Owner

autocorr commented Apr 5, 2020

Hi Jaime, I've added the Swift approximation as an option in a keyword argument as AmmoniaRunner(..., cold=True). This will convert a prior sampling kinetic temperatures and convert them to rotation temperatures. The rotation temperature is only used locally, so the posterior samples will all be in kinetic as drawn from the prior.

I'm finishing up a major refactor and update, so at the exact time of this writing I still need to test that the cube fitting framework still works, but I should get to that in the next couple days. If you'd like to come back and take a look at using it, I'm just finishing up some testing and validation steps while I write-up the paper. I'd be happy to chat about it over video too, since I'm still working on documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants