Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a library of npr or modeling definitions #1148

Open
bernardkwok opened this issue Mar 25, 2021 · 1 comment · Fixed by #1200
Open

Support a library of npr or modeling definitions #1148

bernardkwok opened this issue Mar 25, 2021 · 1 comment · Fixed by #1200
Assignees
Labels
Enhancement New feature or request Interop
Projects
Milestone

Comments

@bernardkwok
Copy link

bernardkwok commented Mar 25, 2021

1.39 Proposal for non-pbr library

Placeholder for proposal to add in a new core library to support non-pbr shading graphs.

  1. This includes the idea to support an "unlit" shader which allows for
    a. Any upstream non-pbr graph to be connected upstream. e.g. a toon or gooch graph, or if unconnected this just becomes a constant colour/value shader.
    b. connection to surfacematerial nodes and thus can be used for material assignment as well as being associated with a displacement shader.
    c. No special case "sampling" nodes need to be attached for code generation of upstream graphs. Currently an must be added and for OSL code generation an addition emissive shader must be added for unit testing (which isn't strictly correct).

    Note that a constant edf node to a surface node is the base functional nodegraph definition. Some codegen efficiencies can be made as needed. e.g. color variant is shown:
    image

  2. A core set of functional nodegraphs for desired effects.

Note: at this point we are not considering shaders which may require additional stages in hardware e.g. a stippled edge shader.

@bernardkwok bernardkwok added Enhancement New feature or request Interop labels Mar 25, 2021
@bernardkwok bernardkwok added this to the 1.39 milestone Mar 25, 2021
@bernardkwok bernardkwok added this to To do in Develop via automation Mar 25, 2021
@bernardkwok bernardkwok moved this from To do to In progress in Develop Mar 26, 2021
@bernardkwok bernardkwok linked a pull request May 13, 2021 that will close this issue
Develop automation moved this from In progress to Done May 14, 2021
@bernardkwok
Copy link
Author

Re-open as current implementation needs to be revisited.

@bernardkwok bernardkwok reopened this Aug 18, 2021
Develop automation moved this from Done to In progress Aug 18, 2021
@kwokcb kwokcb modified the milestones: 1.39, 1.38.4 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Interop
Projects
Develop
  
In progress
Development

Successfully merging a pull request may close this issue.

4 participants