Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Hydra point instancer #18

Closed
sirpalee opened this issue Nov 14, 2019 · 2 comments · Fixed by #225
Closed

Support the Hydra point instancer #18

sirpalee opened this issue Nov 14, 2019 · 2 comments · Fixed by #225
Assignees
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate user Reported by a user

Comments

@sirpalee
Copy link
Contributor

Support the Hydra point instancer for primitives.

Initial support was already added for instancing meshes see render_delegate/instancer.cpp and related files.

A few features are still missing:

  • add support for instancing volumes
  • calculating transformation motion blur for instance matrices

We can use hdEmbree/instancer.cpp as an example implementation.

@sirpalee sirpalee self-assigned this Nov 14, 2019
@sirpalee sirpalee added the enhancement New feature or request label Nov 14, 2019
@nrusch
Copy link
Contributor

nrusch commented Nov 23, 2019

As part of the improvements to instancing, I think the render delegate needs to treat the Rprim that is being instanced as if it is not part of the scene, instead of rendering it. This would match the behavior of Embree and Prman delegates.

Right now, if I create an instancer with 8 instances and a single mesh prototype, I get the 8 instances plus the original prototype in the render.

This may mean continuing to translate the prototype but making it invisible in Arnold, or generating numInstances - 1 ginstance nodes and using the prototype for the last one (with the transform of the final instance) The second approach seems nicer and more Arnold-like, but would require the prototype's transform to be factored into the computation of the instance matrices as well.

@sirpalee
Copy link
Contributor Author

@nrusch found an issue with updating transformation matrices for the point instancer and created a solution in #69

@sirpalee sirpalee added the render delegate Related to the Arnold Render Delegate label Nov 29, 2019
@sirpalee sirpalee changed the title [Render Delegate] Support the point instancer Support the Hydra point instancer Nov 29, 2019
@sirpalee sirpalee added this to To do in Sprint 16 Jan 11, 2020
@sirpalee sirpalee moved this from To do to In progress in Sprint 16 Jan 17, 2020
@sirpalee sirpalee removed this from In progress in Sprint 16 Jan 24, 2020
@sirpalee sirpalee added this to To do in Sprint 17 via automation Jan 24, 2020
@sirpalee sirpalee moved this from To do to In progress in Sprint 17 Jan 24, 2020
@kikou kikou added this to To do in Sprint 18 Feb 7, 2020
@kikou kikou moved this from To do to In progress in Sprint 18 Feb 7, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Feb 14, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Feb 19, 2020
- Fixing matrix updates for instances
- Supporting volume instances
- Fixing source mesh visibility
- Reading constant primvars for volumes
- Changing how instancer primvars are stored
- Improving HdArnoldSetTransform safety

Fixes Autodesk#18
Fixes Autodesk#123
@sirpalee sirpalee moved this from In progress to Review in progress in Sprint 18 Feb 19, 2020
Sprint 18 automation moved this from Review in progress to Done Feb 19, 2020
sebastienblor pushed a commit that referenced this issue Feb 19, 2020
- Fixing matrix updates for instances
- Supporting volume instances
- Fixing source mesh visibility
- Reading constant primvars for volumes
- Changing how instancer primvars are stored
- Improving HdArnoldSetTransform safety

Fixes #18
Fixes #123
@kikou kikou added the user Reported by a user label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate user Reported by a user
Projects
No open projects
Sprint 17
  
In progress
Sprint 18
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants