Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General long-term notes #32

Closed
pcolaianni opened this issue Jul 12, 2018 · 1 comment
Closed

General long-term notes #32

pcolaianni opened this issue Jul 12, 2018 · 1 comment

Comments

@pcolaianni
Copy link
Contributor

pcolaianni commented Jul 12, 2018

I will collect info from multiple PRs into this issue:

  • we are using #pragma once instead of define guards
  • we keep using OpenMS:: namespace explicitly, avoiding using namespace OpenMS;
  • using namespace std; is fine where it actually increases readability
  • convert python to c++ first, and then take care of improving code
  • rename "Targeted" to "TargetedExperiment" for identifiers and methods in code
  • .cpp/.h C++ files should indented using two spaces
  • .cmake (or other cmake related files), build scripts, and docker files should be indented using tab/4 spaces
  • will need to correct EOF consistency
@pcolaianni
Copy link
Contributor Author

About getters/setters:

Non constant versions should only be implemented if there is a desire to modify the underlying value. If not, a copy should be returned.

If performance becomes an issue, then we can start thinking about breaking the above rule. However, I suspect that this will not be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants