Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRMFeatureValidation #70

Closed
3 tasks done
dmccloskey opened this issue Sep 25, 2018 · 4 comments
Closed
3 tasks done

MRMFeatureValidation #70

dmccloskey opened this issue Sep 25, 2018 · 4 comments
Assignees

Comments

@dmccloskey
Copy link
Collaborator

dmccloskey commented Sep 25, 2018

Description

Conversion of MRMFeatureValidation from .py to .cpp. In addition, load_validationData from FileReaderOpenMS class will need to be implemented to read validation data from .csv. Please note that the functionality of load_validationData corresponding to accessing data from a database does not need to be implemented (i.e., db_json_i parameter can be ignored).

Objectives

  • re-implementation of all methods from MRMFeatureValidation
  • re-implementation of load_validationData without DB access functionality

Validation

  • converted and passing unit tests
@pcolaianni pcolaianni self-assigned this Sep 25, 2018
@dmccloskey
Copy link
Collaborator Author

The columns that will need to be read in are the following:
original_filename,sample_name,sample_type,acquisition_date_and_time,acq_method_name,component_name,component_group_name,retention_time,start_time,end_time,used_,calculated_concentration,experiment_id,acquisition_method_id,height,area

@pcolaianni
Copy link
Contributor

Should all read rows be pushed into the vector, or should the value of used decide on that?
@dmccloskey

@dmccloskey
Copy link
Collaborator Author

dmccloskey commented Oct 1, 2018

Good observation. Only the rows with a used_ = true should be read in. This was not done originally, but will minimize the needed data since false rows will not be used at all.

@pcolaianni
Copy link
Contributor

  • Move metrics methods to Utilities
  • use template to support any kind of label type (double, float, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants