/
auth.go
524 lines (470 loc) · 15.8 KB
/
auth.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
package auth
import (
"context"
"encoding/gob"
"fmt"
"net/http"
"strconv"
"strings"
pb "github.com/autograde/quickfeed/ag"
"github.com/autograde/quickfeed/database"
lg "github.com/autograde/quickfeed/log"
"github.com/gorilla/sessions"
"github.com/labstack/echo-contrib/session"
"github.com/labstack/echo/v4"
"github.com/markbates/goth/gothic"
"go.uber.org/zap"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/status"
"gorm.io/gorm"
)
func init() {
gob.Register(&UserSession{})
}
// Session keys.
const (
SessionKey = "session"
UserKey = "user"
Cookie = "cookie"
OutgoingCookie = "Set-Cookie"
)
// Query keys.
const (
State = "state" // As defined by the OAuth2 RFC.
Redirect = "redirect"
)
// UserSession holds user session information.
type UserSession struct {
ID uint64
Providers map[string]struct{}
}
func newUserSession(id uint64) *UserSession {
return &UserSession{
ID: id,
Providers: make(map[string]struct{}),
}
}
func (us *UserSession) enableProvider(provider string) {
us.Providers[provider] = struct{}{}
}
func (us UserSession) String() string {
providers := ""
for provider := range us.Providers {
providers += provider + " "
}
return fmt.Sprintf("UserSession{ID: %d, Providers: %v}", us.ID, providers)
}
// map from session cookies to user IDs.
var cookieStore = make(map[string]uint64)
// Add adds cookie for userID, replacing userID's current cookie, if any.
func Add(cookie string, userID uint64) {
for currentCookie, id := range cookieStore {
if id == userID && currentCookie != cookie {
delete(cookieStore, currentCookie)
}
}
cookieStore[cookie] = userID
}
func Get(cookie string) uint64 {
return cookieStore[cookie]
}
// OAuth2Logout invalidates the session for the logged in user.
func OAuth2Logout(logger *zap.SugaredLogger) echo.HandlerFunc {
return func(c echo.Context) error {
r := c.Request()
w := c.Response()
sess, err := session.Get(SessionKey, c)
if err != nil {
logger.Error(err.Error())
return sess.Save(r, w)
}
logger.Debug(sessionData(sess))
if i, ok := sess.Values[UserKey]; ok {
// If type assertions fails, the recover middleware will catch the panic and log a stack trace.
us := i.(*UserSession)
logger.Debug(us)
// Invalidate gothic user sessions.
for provider := range us.Providers {
sess, err := session.Get(provider+gothic.SessionName, c)
if err != nil {
logger.Error(err.Error())
return err
}
logger.Debug(sessionData(sess))
sess.Options.MaxAge = -1
sess.Values = make(map[interface{}]interface{})
if err := sess.Save(r, w); err != nil {
logger.Error(err.Error())
}
}
}
// Invalidate our user session.
sess.Options.MaxAge = -1
sess.Values = make(map[interface{}]interface{})
if err := sess.Save(r, w); err != nil {
logger.Error(err.Error())
}
return c.Redirect(http.StatusFound, extractRedirectURL(r, Redirect))
}
}
// PreAuth checks the current user session and executes the next handler if none
// was found for the given provider.
func PreAuth(logger *zap.SugaredLogger, db database.Database) echo.MiddlewareFunc {
return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) error {
sess, err := session.Get(SessionKey, c)
if err != nil {
logger.Error(err.Error())
if err := sess.Save(c.Request(), c.Response()); err != nil {
logger.Error(err.Error())
return err
}
return next(c)
}
logger.Debug(sessionData(sess))
if i, ok := sess.Values[UserKey]; ok {
// If type assertions fails, the recover middleware will catch the panic and log a stack trace.
us := i.(*UserSession)
logger.Debug(us)
user, err := db.GetUser(us.ID)
if err != nil {
logger.Error(err.Error())
return OAuth2Logout(logger)(c)
}
logger.Debugf("User: %v", user)
}
return next(c)
}
}
}
func sessionData(session *sessions.Session) string {
if session == nil {
return "<nil>"
}
out := "Values: "
for k, v := range session.Values {
out += fmt.Sprintf("<%s: %v>, ", k, v)
}
out += "Options: "
out += fmt.Sprintf("<%s: %v>, ", "MaxAge", session.Options.MaxAge)
out += fmt.Sprintf("<%s: %v>, ", "Path", session.Options.Path)
out += fmt.Sprintf("<%s: %v>, ", "Domain", session.Options.Domain)
out += fmt.Sprintf("<%s: %v>, ", "Secure", session.Options.Secure)
out += fmt.Sprintf("<%s: %v>, ", "HttpOnly", session.Options.HttpOnly)
out += fmt.Sprintf("<%s: %v>, ", "SameSite", session.Options.SameSite)
return fmt.Sprintf("Session: ID=%s, IsNew=%t, %s", session.ID, session.IsNew, out)
}
// OAuth2Login tries to authenticate against an oauth2 provider.
func OAuth2Login(logger *zap.SugaredLogger, db database.Database) echo.HandlerFunc {
return func(c echo.Context) error {
w := c.Response()
r := c.Request()
provider, err := gothic.GetProviderName(r)
if err != nil {
logger.Error(err.Error())
return echo.NewHTTPError(http.StatusBadRequest, err.Error())
}
var teacher int
if strings.HasSuffix(provider, TeacherSuffix) {
teacher = 1
}
logger.Debugf("Provider: %v ; Teacher: %v", provider, teacher)
qv := r.URL.Query()
logger.Debugf("qv: %v", qv)
redirect := extractRedirectURL(r, Redirect)
logger.Debugf("redirect: %v", redirect)
// TODO: Add a random string to protect against CSRF.
qv.Set(State, strconv.Itoa(teacher)+redirect)
logger.Debugf("State: %v", strconv.Itoa(teacher)+redirect)
r.URL.RawQuery = qv.Encode()
logger.Debugf("RawQuery: %v", r.URL.RawQuery)
url, err := gothic.GetAuthURL(w, r)
if err != nil {
logger.Error(err.Error())
return echo.NewHTTPError(http.StatusBadRequest, err.Error())
}
logger.Debugf("Redirecting to %s to perform authentication; AuthURL: %v", provider, url)
return c.Redirect(http.StatusTemporaryRedirect, url)
}
}
// OAuth2Callback handles the callback from an oauth2 provider.
func OAuth2Callback(logger *zap.SugaredLogger, db database.Database, scms *Scms) echo.HandlerFunc {
return func(c echo.Context) error {
logger.Debug("OAuth2Callback: started")
w := c.Response()
r := c.Request()
qv := r.URL.Query()
logger.Debugf("qv: %v", qv)
redirect, teacher := extractState(r, State)
logger.Debugf("Redirect: %v ; Teacher: %t", redirect, teacher)
provider, err := gothic.GetProviderName(r)
if err != nil {
logger.Error("failed to get gothic provider", zap.Error(err))
return echo.NewHTTPError(http.StatusBadRequest, err.Error())
}
// Add teacher suffix if upgrading scope.
if teacher {
qv.Set("provider", provider+TeacherSuffix)
logger.Debugf("Set('provider') = %v", provider+TeacherSuffix)
}
r.URL.RawQuery = qv.Encode()
logger.Debugf("RawQuery: %v", r.URL.RawQuery)
// Complete authentication.
externalUser, err := gothic.CompleteUserAuth(w, r)
if err != nil {
logger.Error("failed to complete user authentication", zap.Error(err))
return echo.NewHTTPError(http.StatusBadRequest, err.Error())
}
logger.Debugf("externalUser: %v", lg.IndentJson(externalUser))
remoteID, err := strconv.ParseUint(externalUser.UserID, 10, 64)
if err != nil {
logger.Error(err.Error())
return err
}
logger.Debugf("remoteID: %v", remoteID)
// session.Get(name, context) returns an existing session, or a new session if the context does not have an existing session
sess, err := session.Get(SessionKey, c)
if err != nil {
logger.Error(err.Error())
return err
}
logger.Debugf("%s", sessionData(sess))
// Try to get already logged in user.
// If session.Get(...) returns a new session, the check below will be nil.
if sess.Values[UserKey] != nil {
i, ok := sess.Values[UserKey]
if !ok {
logger.Debug("failed to get logged in user from session; logout")
return OAuth2Logout(logger)(c)
}
// If type assertions fails, the recover middleware will catch the panic and log a stack trace.
us := i.(*UserSession)
logger.Debug(us)
// Associate user with remote identity.
if err := db.AssociateUserWithRemoteIdentity(
us.ID, provider, remoteID, externalUser.AccessToken,
); err != nil {
logger.Debugf("Associate failed: %d, %s, %d, %s", us.ID, provider, remoteID, externalUser.AccessToken)
logger.Error("failed to associate user with remote identity", zap.Error(err))
return err
}
logger.Debugf("Associate: %d, %s, %d, %s", us.ID, provider, remoteID, externalUser.AccessToken)
// Enable provider in session.
us.enableProvider(provider)
if err := sess.Save(r, w); err != nil {
logger.Error(err.Error())
return err
}
logger.Debugf("enableProvider: %v, r=%v, w=%v", provider, r, w)
if user, err := db.GetUser(us.ID); err != nil {
// handle
logger.Errorf("Failed to get user: %v", err)
} else {
if ok := updateScm(c, logger, scms, user); !ok {
logger.Debugf("Failed to update SCM for User: %v", user)
}
}
// Enable gRPC requests for session
if token := extractSessionCookie(w); len(token) > 0 {
logger.Debugf("extractSessionCookie: %v", token)
Add(token, us.ID)
} else {
logger.Debugf("no session cookie found in w: %v", w)
}
logger.Debugf("Redirecting: %s", redirect)
return c.Redirect(http.StatusFound, redirect)
}
remote := &pb.RemoteIdentity{
Provider: provider,
RemoteID: remoteID,
AccessToken: externalUser.AccessToken,
}
// Try to get user from database.
user, err := db.GetUserByRemoteIdentity(remote)
switch {
case err == nil:
logger.Debugf("found user: %v", user)
// found user in database; update access token
err = db.UpdateAccessToken(remote)
if err != nil {
logger.Error("failed to update access token for user", zap.Error(err), zap.String("user", user.String()))
return err
}
logger.Debugf("access token updated: %v", remote)
case err == gorm.ErrRecordNotFound:
logger.Debug("user not found in database; creating new user")
// user not in database; create new user
user = &pb.User{
Name: externalUser.Name,
Email: externalUser.Email,
AvatarURL: externalUser.AvatarURL,
Login: externalUser.NickName,
}
err = db.CreateUserFromRemoteIdentity(user, remote)
if err != nil {
logger.Error("failed to create remote identify for user", zap.Error(err), zap.String("user", user.String()))
return err
}
logger.Debugf("New user created: %v, remote: %v", user, remote)
default:
logger.Error("failed to fetch user for remote identity", zap.Error(err))
}
// in case this is a new user we need a user object with full information,
// otherwise frontend will get user object where only name, email and url are set.
user, err = db.GetUserByRemoteIdentity(remote)
if err != nil {
logger.Error(err.Error())
return err
}
logger.Debugf("Fetching full user info for %v, user: %v", remote, user)
// Register user session.
us := newUserSession(user.ID)
us.enableProvider(provider)
sess.Values[UserKey] = us
logger.Debugf("New Session: %s", us)
// save the session to a store in addition to adding an outgoing ('set-cookie') session cookie to the response.
if err := sess.Save(r, w); err != nil {
logger.Error(err.Error())
return err
}
logger.Debugf("Session.Save: %v", sess)
if ok := updateScm(c, logger, scms, user); !ok {
logger.Debugf("Failed to update SCM for User: %v", user)
}
// Register session and associated user ID to enable gRPC requests for this session.
if token := extractSessionCookie(w); len(token) > 0 {
logger.Debugf("extractSessionCookie: %v", token)
Add(token, us.ID)
} else {
logger.Debugf("No session cookie found in w: %v", w)
}
logger.Debugf("Redirecting: %s", redirect)
return c.Redirect(http.StatusFound, redirect)
}
}
// AccessControl returns an access control middleware. Given a valid context
// with sufficient access the next handler is called. Missing or invalid
// credentials results in a 401 unauthorized response.
func AccessControl(logger *zap.SugaredLogger, db database.Database, scms *Scms) echo.MiddlewareFunc {
return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) error {
sess, err := session.Get(SessionKey, c)
if err != nil {
logger.Error(err.Error())
// Save fixes the session if it has been modified
// or it is no longer valid due to newUserSess change of keys.
if err := sess.Save(c.Request(), c.Response()); err != nil {
logger.Error(err.Error())
return err
}
return next(c)
}
logger.Debug(sessionData(sess))
i, ok := sess.Values[UserKey]
if !ok {
return next(c)
}
// If type assertion fails, the recover middleware will catch the panic and log a stack trace.
us := i.(*UserSession)
logger.Debug(us)
user, err := db.GetUser(us.ID)
if err != nil {
logger.Error(err.Error())
// Invalidate session. This could happen if the user has been entirely remove
// from the database, but a valid session still exists.
if err == gorm.ErrRecordNotFound {
logger.Error(err.Error())
return OAuth2Logout(logger)(c)
}
logger.Error(echo.ErrUnauthorized.Error())
return next(c)
}
c.Set(UserKey, user)
// TODO: Add access control list.
// - Extract endpoint.
// - Verify whether the user has sufficient rights. This
// can be a simple hash map. A user should be able to
// access /users/:uid if the user's id is uid.
// - Not authorized: return c.NoContent(http.StatusUnauthorized)
// - Authorized: return next(c)
return next(c)
}
}
}
func updateScm(ctx echo.Context, logger *zap.SugaredLogger, scms *Scms, user *pb.User) bool {
foundSCMProvider := false
for _, remoteID := range user.RemoteIdentities {
scm, err := scms.GetOrCreateSCMEntry(logger.Desugar(), remoteID.GetProvider(), remoteID.GetAccessToken())
if err != nil {
logger.Errorf("Unknown SCM provider: %v", err)
continue
}
foundSCMProvider = true
ctx.Set(remoteID.Provider, scm)
}
if !foundSCMProvider {
logger.Debugf("No SCM provider found for user %v", user)
}
return foundSCMProvider
}
func extractRedirectURL(r *http.Request, key string) string {
// TODO: Validate redirect URL.
url := r.URL.Query().Get(key)
if url == "" {
url = "/"
}
return url
}
func extractState(r *http.Request, key string) (redirect string, teacher bool) {
// TODO: Validate redirect URL.
url := r.URL.Query().Get(key)
teacher = url != "" && url[:1] == "1"
if url == "" || url[1:] == "" {
return "/", teacher
}
return url[1:], teacher
}
func extractSessionCookie(w *echo.Response) string {
// Helper function that extracts an outgoing session cookie.
outgoingCookies := w.Header().Values(OutgoingCookie)
for _, cookie := range outgoingCookies {
if c := strings.Split(cookie, "="); c[0] == SessionKey {
token := strings.Split(cookie, ";")[0]
return token
}
}
return ""
}
var (
ErrInvalidSessionCookie = status.Errorf(codes.Unauthenticated, "Request does not contain a valid session cookie.")
ErrContextMetadata = status.Errorf(codes.Unauthenticated, "Could not obtain metadata from context")
)
func UserVerifier() grpc.UnaryServerInterceptor {
return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
meta, ok := metadata.FromIncomingContext(ctx)
if !ok {
return nil, ErrContextMetadata
}
newMeta, err := userValidation(meta)
if err != nil {
return nil, err
}
// create new context with user id instead of cookie for use internally
newCtx := metadata.NewIncomingContext(ctx, newMeta)
resp, err := handler(newCtx, req)
return resp, err
}
}
// userValidation returns modified metadata containing a valid user.
// An error is returned if the user is not authenticated.
func userValidation(meta metadata.MD) (metadata.MD, error) {
for _, cookie := range meta.Get(Cookie) {
if user := Get(cookie); user > 0 {
meta.Set(UserKey, strconv.FormatUint(user, 10))
return meta, nil
}
}
return nil, ErrInvalidSessionCookie
}