Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe switch to posts_pre_query #7

Open
mjangda opened this issue Nov 17, 2016 · 2 comments
Open

Maybe switch to posts_pre_query #7

mjangda opened this issue Nov 17, 2016 · 2 comments

Comments

@mjangda
Copy link
Member

mjangda commented Nov 17, 2016

Right now, we hack our way around WP_Query to prevent it from doing the database query.

WordPress 4.6 added a new filter (https://developer.wordpress.org/reference/hooks/posts_pre_query/) that lets you hook in and skip the query by passing in the necessary post objects. This could simplify the Advanced Post Cache code quite a bit.

@ethitter
Copy link
Contributor

I've a long flight tomorrow, which seems a perfect opportunity to work on this.

@youri--
Copy link

youri-- commented Mar 6, 2019

Since this is open issue is quite old, I'm wondering the same as #12 .. Is this plugin safe to use or will I run into issues like #11?

I'm looking to maybe implement this on a multi-site (running most notably Event Espresso which makes use of extra DB tables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants