Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined index and property notices #47

Closed
matthewpizza opened this issue Apr 2, 2015 · 2 comments
Closed

Undefined index and property notices #47

matthewpizza opened this issue Apr 2, 2015 · 2 comments

Comments

@matthewpizza
Copy link

We’re seeing a lot of the following notices in debug.log:

[02-Apr-2015 21:33:01 UTC] PHP Notice:  Undefined index: HTTP_HOST in advanced-cache.php on line 388
[02-Apr-2015 21:33:01 UTC] PHP Notice:  Undefined index: REQUEST_METHOD in advanced-cache.php on line 389
[02-Apr-2015 21:33:01 UTC] PHP Notice:  Undefined property: batcache::$query in advanced-cache.php on line 391

The “Undefined property” notice is related to #36, but the other two we don’t see mentioned in any issues or PRs.

We wanted to touch base before submitting a pull request since these notices might be related to our setup, which is also running behind Varnish. Thanks!

@Viper007Bond
Copy link
Contributor

Yeah, those issues are related to your setup. It looks like you need to be passing through the Host: header and the request method. If you're missing Host:, I wouldn't be surprised if you're missing other important headers too.

@matthewpizza
Copy link
Author

@Viper007Bond Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants