Setup Wizard copy updates #435
Conversation
| @@ -350,18 +350,27 @@ a.instant-articles-button { | |||
| font-weight: bold; | |||
| } | |||
| .instant-articles-advanced-settings { | |||
There was a problem hiding this comment.
Selector now targets a
instead of an tag so text-decoration and display properties aren't necessary.
There was a problem hiding this comment.
Just check my inline comments.
| if ( text.indexOf( '►' ) !== -1 ) { | ||
| text = text.replace( '►', '▼' ); | ||
| jQuery( '.instant-articles-wizard-toggle a' ).on( 'click', function () { | ||
| $advancedSettingsContainer = jQuery('.instant-articles-advanced-settings'); |
There was a problem hiding this comment.
Spacing is broken here.
Should be:
jQuery( '.instant-articles-advanced-settings' );
| jQuery( '.instant-articles-wizard-toggle a' ).on( 'click', function () { | ||
| $advancedSettingsContainer = jQuery('.instant-articles-advanced-settings'); | ||
| if ( $advancedSettingsContainer.attr('data-state') === 'closed' ) { | ||
| $advancedSettingsContainer.attr('data-state', 'opened'); |
There was a problem hiding this comment.
Review the spacing to be like this:
$var.function( 'parameter spaced', 'another param' );
| @@ -350,18 +350,27 @@ a.instant-articles-button { | |||
| font-weight: bold; | |||
| } | |||
| .instant-articles-advanced-settings { | |||
There was a problem hiding this comment.
Just check my inline comments.
|
@demoive Take a look on the conflicts. Probably you need to rebase it and then fix conflicts, before making it ready. |
| <span class="page-not-enabled"> | ||
| This page has not been signed up yet. | ||
| <a href="https://www.facebook.com/instant_articles/signup?redirect_uri=<?php echo urlencode( $settings_url ) ?>&page_id=<?php echo urlencode( $page[ 'page_id' ] ) ?>">Sign Up</a>. | ||
| First, <a href="https://www.facebook.com/instant_articles/signup?redirect_uri=<?php echo urlencode( $settings_url ) ?>&page_id=<?php echo urlencode( $page[ 'page_id' ] ) ?>">sign up</a> |
There was a problem hiding this comment.
We should use rawurlencode() over urlencode() here
There was a problem hiding this comment.
I've looked at the difference between those two functions, and to be honest, I don't know the specs (e.g. RFC 3986) well enough to be able to determine which circumstances merits each one (if I'm faced with this again in the future). Any insight there?
I am updating the PR with your request.
This PR:
slideToggle()animation for opening/closing the section no longer exists