This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Don't try to load embeds compat unless we're in Instant Articles context #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext to prevent outputting of IA-version embed on regular frontend/in visual editor replace op-social with op-interactive (op-social is deprecated)
…ev/facebook-instant-articles-wp into rinatkhaziev-fix-jetpack-fb-compat
everton-rosario
approved these changes
Jan 31, 2017
| @@ -79,7 +85,7 @@ public static function facebook_embed_handler( $matches, $attr, $url ) { | |||
| $locale = 'en_US'; | |||
| } | |||
|
|
|||
| return '<figure class="op-social"><iframe><script src="https://connect.facebook.net/' . $locale . '/sdk.js#xfbml=1&version=v2.6" async></script><div class="fb-post" data-href="' . esc_url( $url ) . '"></div></iframe></figure>'; | |||
| return '<figure class="op-interactive"><iframe><script src="https://connect.facebook.net/' . $locale . '/sdk.js#xfbml=1&version=v2.6" async></script><div class="fb-post" data-href="' . esc_url( $url ) . '"></div></iframe></figure>'; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #457 and using the solution introduced by #568.
It prevents the compat layer from messing with the regular FE output, running only during the Instant Article transformation.