Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar: WooCommerce products duplicate if infinite scroll is enabled #23

Closed
laurelfulford opened this issue Feb 24, 2018 · 0 comments
Closed

Comments

@laurelfulford
Copy link
Contributor

laurelfulford commented Feb 24, 2018

This issue was originally reported by @SiobhyB in 4975-wpcom-themes:

Steps to replicate

  1. Activate Lodestar on a site with the Business plan.
  2. Install the WooCommerce plugin.
  3. Navigate to Products > Add New and add more than seven products to your shop.
  4. Navigate to Settings > Reading in your site's /wp-admin area to ensure that Infinite Scroll is enabled.
  5. View the Shop page.

Result

In the following screenshot, you can see that the following five products are repeated:

  • mushrooms sauce with truffles
  • pecorino cheese and summer truffles
  • porcini and truffle cream 200g
  • porcini mushrooms and summer truffle cream

The products are still duplicated with infinite scroll turned off.

It also only seems to happen on Business sites, and doesn't happen on self-hosted sites.

Expected

I expected for all the products that I'd added to display on the Shop page, and didn't expect them to display more than once.

This is similar to #10.

@laurelfulford laurelfulford added this to the Lodestar milestone Feb 24, 2018
@jeffikus jeffikus self-assigned this Feb 27, 2018
jeffikus added a commit that referenced this issue Jun 29, 2018
jeffikus added a commit that referenced this issue Jun 29, 2018
…m:Automattic/themes into jetpack_infinite_scroll_wc_products_fixes

* 'jetpack_infinite_scroll_wc_products_fixes' of github.com:Automattic/themes:
  Shoreditch: Fixes Jetpack Infinite Scroll WC issues. Closes #24
  Lodestar: Fixes Jetpack Infinite Scroll WC issues. Closes #23
  Button 2: Fixes Jetpack Infinite Scroll WC issues.
  Pique: Fixes Jetpack Infinite Scroll WC issues.
  Karuna: adds correct WC filters on return functions.
  Libre 2: Revert CSS fix as the Jetpack fix is in core files now.
  Libre 2: Fixes Jetpack Infinite Scroll WC issues.
  Dara: Fixes Jetpack Infinite Scroll WC issues. Closes #10
  Dyad 2: Fixes Jetpack Infinite Scroll WC issues.
  Independent Publisher 2: Fixes Jetpack Infinite Scroll WC issues.
  Radcliffe 2: Fixes Jetpack Infinite Scroll WC issues.

# Conflicts:
#	dara/inc/woocommerce.php
#	dyad-2/inc/woocommerce.php
#	independent-publisher-2/inc/woocommerce.php
#	karuna/inc/woocommerce.php
#	libre-2/inc/woocommerce.php
#	lodestar/inc/woocommerce.php
#	pique/inc/woocommerce.php
#	radcliffe-2/inc/woocommerce.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants