-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me: Security - 2FA - Compact notice close link is not aligned #21
Labels
[Feature] User & Account Settings (/me)
Settings and tools for managing your WordPress.com user account.
Good First Issue
Small, contained issues.
Security
[Type] Bug
Milestone
Comments
This seems to have already been fixed, likely by pre-OSS PR 12107. |
sirreal
pushed a commit
that referenced
this issue
Dec 5, 2018
jsx-classname-namespace: Mark element in render as root only if returned
sirreal
pushed a commit
that referenced
this issue
Dec 5, 2018
jsx-classname-namespace: Mark element in render as root only if returned
sirreal
pushed a commit
that referenced
this issue
Dec 6, 2018
jsx-classname-namespace: Mark element in render as root only if returned
sirreal
pushed a commit
that referenced
this issue
Dec 11, 2018
jsx-classname-namespace: Mark element in render as root only if returned
sgomes
pushed a commit
that referenced
this issue
Jan 29, 2020
* First pass at allowing reloading * Build after installing, so we can use GitHub branches as dependencies * Use npm instead of make for postinstall * Try using postinstall-build for postinstall? * Package: need to include index.js, so it can be built. * Package: need to include Makefile, too. * Wait for a message from the iframe to trigger onload() * Run the test suite twice - once normally, then once after reload. * Add myself as a contributor * Fix some code formatting bugs * Let prepublish build the lib when installed as a dependency * Bump package version to v4.0.0 * Don't add index.js and Makefile to npm package
sgomes
pushed a commit
that referenced
this issue
Feb 18, 2020
* First pass at allowing reloading * Build after installing, so we can use GitHub branches as dependencies * Use npm instead of make for postinstall * Try using postinstall-build for postinstall? * Package: need to include index.js, so it can be built. * Package: need to include Makefile, too. * Wait for a message from the iframe to trigger onload() * Run the test suite twice - once normally, then once after reload. * Add myself as a contributor * Fix some code formatting bugs * Let prepublish build the lib when installed as a dependency * Bump package version to v4.0.0 * Don't add index.js and Makefile to npm package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] User & Account Settings (/me)
Settings and tools for managing your WordPress.com user account.
Good First Issue
Small, contained issues.
Security
[Type] Bug
I was running through the steps to disable and then re-enable 2FA today and came to the step where it asked me to type my verification code. Since I had just done so to enter /me, I had to wait a bit. I got this notice and the X was underlined and not aligned to the top right. It was also is-info and would probably make more sense as a is-warning.
Error message too:
![image](https://cloud.githubusercontent.com/assets/7233112/11217980/07bf493c-8d21-11e5-9312-4c984f3a77ef.png)
Should be simple CSS and HTML class fixes here
The text was updated successfully, but these errors were encountered: