-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Everything in <prev plan>, includes:" shouldn't rely on the grid position. #91867
Comments
Hi @southp, I think there are two possible solutions to this:
|
Great points, @aneeshd16 . I'm thinking if we can actually combine the both, since a clickable "Everything in..." can also solve the particular issue of the 1st approach that the owned plan is not in the plans grid. If that's acceptable, we can first make it right, and then make it better :) Is there other reason we should keep it as referring to the previous plan on the grid? Just curious to learn if there is any benefit that I'm overlooking. |
That's true!
I was thinking it would make it easier since users can scan the plans from left-right to view plan features, but I realized that it's not true for tablet and mobile. Meanwhile, the PR is ready for review: #92016 |
@aneeshd16 I'm closing this issue since the accompanied PR has been launched. For the idea of the clickable "Everything in ...", should we create a follow-up issue for documenting the idea? |
Thanks @southp! Created a follow-up here: https://github.com/Automattic/martech/issues/3130 |
To shorten the feature list, the plans grid puts "everything in , includes:" copy on top to emphasize that the higher-tier plan includes everything in the lower-tier one. However, it appears to rely on the grid position of a plan card rather than the logical order between these plans. There are three identified issues due to this:
1. The latest report from @niranjan-uma-shankar from pdvytD-EC-p2:
On a Creator site, the Entrepreneur plan shows "everything in Explorer" rather than "everything in Creator":
2. On mobile, the copy is missing
See #90196
3. on tablet, the copy is missing for the left-most plan card in the 2nd row:
e.g.
The text was updated successfully, but these errors were encountered: