Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woo Blaze Jetpack connection copy #90070

Merged
merged 16 commits into from
May 16, 2024

Conversation

Alameen688
Copy link
Contributor

@Alameen688 Alameen688 commented Apr 30, 2024

Proposed Changes

  • This PR updates the connect auth and sign-up page copy for Woo Blaze

Testing Instructions

  • Create a WooCommerce site, and make sure the Jetpack plugin is deactivated or not installed
  • Point widgets.wp.com to your WP Sandbox.
  • Run yarn start to start calypso
  • Create a plugin build from the woo-blaze plugin repo and install it in your test blog OR run locally as described in repo readme.
  • cd apps/blaze-dashboard and yarn dev --sync to sync blaze dashboard to WP sandbox OR run the commands here Update Woo Blaze Jetpack connection copy #90070 (comment)
  • In WP Admin, Go to Marketing -> Blaze for WooCommerce
  • Click Connect now button and you should see the Jetpack connect flow.

For existing connected users you should see the following connect screen:
sample-connect

For a new user/user without a previous connection attempt you should see the following connect screens:
new user flow
email confirmationemail content

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Apr 30, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~76 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +449 B  (+0.0%)      +76 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Alameen688 Alameen688 force-pushed the add/woo-blaze-jetpack-connection branch 2 times, most recently from 7a2e9fc to 47d342a Compare May 1, 2024 16:39
@Alameen688 Alameen688 marked this pull request as ready for review May 3, 2024 00:12
@Alameen688 Alameen688 requested a review from sbarbosa May 3, 2024 00:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 3, 2024
@sbarbosa sbarbosa requested a review from therocket-gr May 3, 2024 12:31
@sbarbosa
Copy link
Contributor

sbarbosa commented May 3, 2024

Hi @Alameen688!
We have a PR almost ready with the changes of the new connection page #90160.

Checking this PR; I think we will need to revert some changes to adapt them to that other PR. I think that the only changes we need to maintain are:

  • Changes to the jetpack-client code
  • Redirection using the connect_url config prop

From our last sync, I think the changes to the connection-info URL are not necessary, because the redirection will be to the backend, and not the frontend.

We can wait until we merged that other PR, and then revert back the changes that are outdated. Let me know what you think.

@Alameen688
Copy link
Contributor Author

I think we will need to revert some changes to adapt them to that other PR

Yes, I agree. Those changes were just a placeholder for testing pending the implementation of the connect UI. And yes, we don't need the connection-info URL it was under the assumption that the new connect UI on the dashboard might be a separate page but I can see in the other PR #90160 that it is a component conditionally rendered under the setup page/URL.

Also, a long explanation for the connection-info page - as I mentioned in our sync is that it doesn't do anything in this PR it's just an empty placeholder page for when the page reloads to trigger the serverside logic that redirects to the jetpack connection page. the connect URL can be the setup URL or home URL (i.e. just the wc-blaze path), just needed a URL to trigger the onboarding logic which is handled server side, it could have been a window.reload on the client but we just have it as a connect_url to give control/flexibility to the server of what happens when the connect button is clicked in case of a change in the redirect flow, so client-side code changes won't be needed

@Alameen688 Alameen688 force-pushed the add/woo-blaze-jetpack-connection branch from a2a99e5 to c78e824 Compare May 6, 2024 14:57
@Alameen688 Alameen688 changed the title Add Jetpack Connect for Woo Blaze Add connection integration to Blaze dashboard May 6, 2024
Copy link
Contributor

@sbarbosa sbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @Alameen688.
The code looks great!

@Alameen688 Alameen688 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 6, 2024
@Alameen688 Alameen688 force-pushed the add/woo-blaze-jetpack-connection branch from 201b385 to 5b46325 Compare May 6, 2024 18:09
@Alameen688 Alameen688 changed the title Add connection integration to Blaze dashboard Update Blaze Jetpack connect copy May 6, 2024
@Alameen688 Alameen688 force-pushed the add/woo-blaze-jetpack-connection branch from 5b46325 to f7c169b Compare May 6, 2024 18:10
@Alameen688 Alameen688 changed the title Update Blaze Jetpack connect copy Update Woo Blaze Jetpack connect copy May 6, 2024
@Alameen688 Alameen688 changed the title Update Woo Blaze Jetpack connect copy Update Woo Blaze Jetpack connection copy May 6, 2024
Copy link
Contributor

@therocket-gr therocket-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works as described
code changes LGTM

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/woo-blaze-jetpack-connection on your sandbox.

@Alameen688 Alameen688 merged commit d7be710 into trunk May 16, 2024
11 checks passed
@Alameen688 Alameen688 deleted the add/woo-blaze-jetpack-connection branch May 16, 2024 20:40
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants