-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Woo Blaze Jetpack connection copy #90070
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~76 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
7a2e9fc
to
47d342a
Compare
Hi @Alameen688! Checking this PR; I think we will need to revert some changes to adapt them to that other PR. I think that the only changes we need to maintain are:
From our last sync, I think the changes to the connection-info URL are not necessary, because the redirection will be to the backend, and not the frontend. We can wait until we merged that other PR, and then revert back the changes that are outdated. Let me know what you think. |
Yes, I agree. Those changes were just a placeholder for testing pending the implementation of the connect UI. And yes, we don't need the connection-info URL it was under the assumption that the new connect UI on the dashboard might be a separate page but I can see in the other PR #90160 that it is a component conditionally rendered under the setup page/URL. Also, a long explanation for the connection-info page - as I mentioned in our sync is that it doesn't do anything in this PR it's just an empty placeholder page for when the page reloads to trigger the serverside logic that redirects to the jetpack connection page. the connect URL can be the setup URL or home URL (i.e. just the |
apps/blaze-dashboard/src/pages/setup/components/blaze-disabled.jsx
Outdated
Show resolved
Hide resolved
a2a99e5
to
c78e824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @Alameen688.
The code looks great!
201b385
to
5b46325
Compare
5b46325
to
f7c169b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works as described
code changes LGTM
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Proposed Changes
Testing Instructions
widgets.wp.com
to your WP Sandbox.yarn start
to start calypsoapps/blaze-dashboard
andyarn dev --sync
to sync blaze dashboard to WP sandbox OR run the commands here Update Woo Blaze Jetpack connection copy #90070 (comment)Marketing
->Blaze for WooCommerce
Connect now
button and you should see the Jetpack connect flow.For existing connected users you should see the following connect screen:
For a new user/user without a previous connection attempt you should see the following connect screens:
Pre-merge Checklist