Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automattic for Agencies: Redesign hosting marketplace page #90890

Merged

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented May 20, 2024

Resolves https://github.com/Automattic/jetpack-roadmap/issues/1563

Proposed Changes

This PR redesigns the hosting marketplace page

Testing Instructions

  1. Open the A4A live link.
  2. Visit the Marketplace > Hosting page and verify the UI is redesigned as shown below and matches with the latest design (link on the ticket). Also, verify it works well on the screen sizes.

screencapture-agencies-localhost-3000-marketplace-hosting-2024-05-20-17_22_42

Screenshot 2024-05-20 at 5 25 11 PM

Mobile view:

Screenshot 2024-05-21 at 8 55 00 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin self-assigned this May 20, 2024
@yashwin yashwin added A8c Agencies [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels May 20, 2024
@matticbot
Copy link
Contributor

matticbot commented May 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1026 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace      +4079 B  (+0.7%)    +1197 B  (+0.6%)
a8c-for-agencies-overview          -196 B  (-0.1%)     -802 B  (-1.2%)
a8c-for-agencies-migrations        +196 B  (+0.1%)     +582 B  (+1.0%)
settings-performance                +13 B  (+0.0%)      +49 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-90889-revert-90837-update/a4a/hosting-page-redesign on your sandbox.

@yashwin yashwin removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 21, 2024
@yashwin yashwin force-pushed the revert-90889-revert-90837-update/a4a/hosting-page-redesign branch from 0b521cd to c93ec21 Compare May 21, 2024 10:14
Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. LGTM 🚢

@yashwin yashwin force-pushed the revert-90889-revert-90837-update/a4a/hosting-page-redesign branch from c93ec21 to a4269fe Compare May 21, 2024 11:47
@yashwin yashwin merged commit 382859f into trunk May 21, 2024
11 checks passed
@yashwin yashwin deleted the revert-90889-revert-90837-update/a4a/hosting-page-redesign branch May 21, 2024 12:14
@jeffgolenski
Copy link
Member

hey hey @yashwin thanks for fixing all that functionality so quickly. Just 1 issue I noticed.

  1. Content width of the Special limited time migration offer box - can you max-width the .a4a-migration-offer__description to 850px?Just makes it easier to skim through

Before
CleanShot 2024-05-24 at 16 43 47@2x

After
CleanShot 2024-05-24 at 16 46 45@2x

Thanks my friend!

@yashwin
Copy link
Contributor Author

yashwin commented Jun 10, 2024

Sorry for the delay on this, @jeffgolenski. I have made this change here: #91555 as this PR was already merged. Thanks for the feedback! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants