Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter flake and mypy checks #230

Closed
ravinkohli opened this issue May 21, 2021 · 0 comments
Closed

Stricter flake and mypy checks #230

ravinkohli opened this issue May 21, 2021 · 0 comments
Assignees
@ravinkohli
Labels
enhancement New feature or request
Projects
Roadmap release v0.1.0

Comments

@ravinkohli
Copy link
Contributor

There are a few if checks in the code that don't make sense. By making our checks stricter usingmypy --warn-unreachable. Along with this, there are plenty of other checks that can help improve the quality of our code. Check this for more info.
@ravinkohli ravinkohli self-assigned this May 21, 2021
@ravinkohli ravinkohli added the enhancement New feature or request label May 21, 2021
@ravinkohli ravinkohli added this to To do in Roadmap via automation May 21, 2021
@ravinkohli ravinkohli assigned ravinkohli and unassigned ravinkohli May 21, 2021
@ravinkohli ravinkohli mentioned this issue May 25, 2021
Merged
@ravinkohli ravinkohli added this to To do in release v0.1.0 Oct 26, 2021
@ravinkohli ravinkohli moved this from To do to Done in release v0.1.0 Oct 26, 2021
Roadmap automation moved this from To do to Done Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinkohli ravinkohli

Labels
enhancement New feature or request
Projects
Roadmap
Done
release v0.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ravinkohli