-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure SMBO #55
Comments
Hi,
I think we don't use the |
Right now, the smbo class (which is not named smac) plugs together a lot of stuff. For example, the smbo class does not really need to know the TAE since only the intial design and the intensification issues TA runs. I don't think that Maybe it would be over-engineered to add a builder class. I don't know.
Yes, this would be the next step. |
Good point, the SMBO class doesn't need to know about the TAE. But if we have a builder, it should be responsible for creating the whole object, thus the init should be empty afterwards. What about the following to still keep it simple:
I'm also not sure if it would be overengineering, but it would certainly make unit tests easier if we add more options for the user. |
ok, sounds good. I will start to implement it. |
* add facade package * add smac facade * use utils.constants everywhere * FIX minimal cost for log-cost has to be larger than 0
Hi,
I would like to propose the following restructuring. In particular, the smbo class is right now responsible for too much stuff.
__init__
of smbo)ExecuteTARun.start
btw: we have some methods in the
BaseSolver
which we never use, e.g.,init_last_iteration
,from_iteration
,save_iteration
andcreate_save_dir
. Should we delete these?Best,
Marius
The text was updated successfully, but these errors were encountered: