Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nuget.config in condo container #13

Open
jeffreypmoran opened this issue Oct 15, 2019 · 2 comments
Open

Include nuget.config in condo container #13

jeffreypmoran opened this issue Oct 15, 2019 · 2 comments

Comments

@jeffreypmoran
Copy link

I am hitting 401 errors when running condo run on my local machine. Based on feedback from @sjk07, this can be resolved by including a user's nuget.config file in the condo container that is created here -

resp, err := cli.ContainerCreate(ctx, &container.Config{

@dmccaffery
Copy link
Member

There are many issues with taking this approach in the CLI; meaning, using command line arguments to manipulate container internals. NuGet is not the only authenticated resource supported by condo.

Docker, NPM, Go Modules, etc. are also authenticated. There is no “good” way to support args for all of these.

The CLI running a container is a stop-gap to a rewrite of condo functionality without requiring the MSBuild dependency. At least that was the plan way back when.

I’m not a maintainer of these repositories anymore, but I thought I’d share some context.

Yes. An arg could be added to volume map the nuget config file on the local system through some form of platform discovery of the host. This will not work for all scenarios; however, and will also be difficult to handle correctly and to maintain as nuget config files are stacked and merged from project + solution + user + machine. One would have to ensure volume mapping of all of them to work correctly for all use cases.

@dmccaffery
Copy link
Member

Another important comment: condo was never intended for local machine build. It’s intended as a ci/cd system.

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants