Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitflow): add support for reverting merge commits on master #101

Closed
dmccaffery opened this issue Jun 26, 2017 · 2 comments
Closed

feat(gitflow): add support for reverting merge commits on master #101

dmccaffery opened this issue Jun 26, 2017 · 2 comments
Assignees
Milestone

Comments

@dmccaffery
Copy link
Member

Currently, some source control servers that enforce branch policies require a --no-ff merge to master, which impacts the ability to perform gitflow correctly.

The recommended solution is the following:

  • when current branch is master
  • when build is a server-side build (CI)
  • when HEAD commit is a merge commit
  • when merge commit has no diff to HEAD~1 commit
  • when HEAD~1 contains NO_CI (versioned by condo)
  • revert merge commit
  • force push HEAD~1 commit as new HEAD
@dmccaffery dmccaffery added this to the vnext milestone Jun 26, 2017
@dmccaffery dmccaffery self-assigned this Jun 26, 2017
@sjk07
Copy link
Member

sjk07 commented Mar 21, 2018

is this something we still want to do? AFAIK this is only an issue in VSTS. Using a forking strategy will remove the need for such a feature.

@dmccaffery
Copy link
Member Author

Agreed. We can close.

@ghost ghost removed the in progress label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants