Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vsts): set branch to target branch for pull requests #53

Closed
dmccaffery opened this issue Mar 27, 2017 · 1 comment · Fixed by #130
Closed

fix(vsts): set branch to target branch for pull requests #53

dmccaffery opened this issue Mar 27, 2017 · 1 comment · Fixed by #130
Assignees
@dmccaffery
Labels
bug
Projects
condo
Milestone
vnext

Comments

@dmccaffery
Copy link
Member

When building a pull request using a VSTS agent, it is currently not possible to process the automatic semver correctly since VSTS does not expose either the source or target branch of a pull request.

We would like to be able to process semver correctly within condo for the VSTS agent.

This is being tracked/blocked by:

microsoft/azure-pipelines-tasks#2147
@dmccaffery dmccaffery added the bug label Mar 27, 2017
@dmccaffery dmccaffery self-assigned this Mar 27, 2017
@dmccaffery dmccaffery added this to Blocked in condo Mar 27, 2017
@dmccaffery dmccaffery added this to the vnext milestone May 30, 2017
@sjk07 sjk07 changed the title bug(vsts): set branch to target branch for pull requests fix(vsts): set branch to target branch for pull requests Jul 22, 2017
@dmccaffery dmccaffery added ready and removed blocked labels Sep 11, 2017
@dmccaffery
Copy link
Member Author

This is now ready, based on the following ENVARS:

system.pullRequest.pullRequestId
system.pullRequest.sourceBranch
system.pullRequest.targetBranch

@dmccaffery dmccaffery mentioned this issue Oct 13, 2017
Merged
@ghost ghost removed the in progress label Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmccaffery dmccaffery

Labels
bug
Projects
No open projects
condo
Blocked
Milestone
vnext
Development

Successfully merging a pull request may close this issue.

feat(docker): add docker push support automotiveMastermind/condo
1 participant
@dmccaffery