Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FoxDriver dependency, use GeckoDriver instead #5

Open
autonome opened this issue Nov 13, 2018 · 4 comments
Open

Remove FoxDriver dependency, use GeckoDriver instead #5

autonome opened this issue Nov 13, 2018 · 4 comments

Comments

@autonome
Copy link
Owner

FoxDriver is basically unsupported. We should use GeckoDriver directly.

https://github.com/mozilla/geckodriver

@TechQuery
Copy link
Collaborator

WebDriver is based on HTTP, which can't send data by the server proactively, it's difficult to implement APIs such as page.on('console') or page.on('error').

And one more layer of proxy would reduce the performance of puppeteer-fx, not to mention Java-based Selenium driver.

@TechQuery
Copy link
Collaborator

TechQuery commented Mar 15, 2019

But there is a problem: I find nothing about Promise resolving of Console evaluating in the document of Remote Debugging Protocol, many Async methods may become impossible...

Or Firefox is adapting CDP?

@autonome
Copy link
Owner Author

Maybe someday it will... https://bugzilla.mozilla.org/show_bug.cgi?id=1323098

My understanding that is that Selenium is a layer above GeckoDriver, so it would not be needed.

However, if you are correct about async APIs not being possible, then maybe we cannot do it.

The problem of FoxDriver remains. I have not looked through that code enough to know whether it's reasonable to fix it.

I would like to use something that is supported and standardized. I had hoped GeckoDriver would be that choice.

@TechQuery
Copy link
Collaborator

Someone is developing another Puppeteer package based on a custom-built Firefox...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants