Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyproject.toml to exclude build, experimental etc. #170

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update pyproject.toml to exclude build, experimental etc. #170

merged 1 commit into from
Jun 13, 2023

Conversation

outtanames
Copy link
Contributor

@outtanames outtanames commented Jun 13, 2023 •
edited
Loading

We've been inadvertently including build, experimental in Pypi releases due to malformed pyproject excludes.

Checks

  • make lint: I've run make lint to lint the changes in this PR.
  • make test: I've made sure the tests (make test-cpu or make test) are passing.
  • Additional tests:
    • Benchmark tests (when contributing new models)
    • GPU/HW tests

@spillai
Copy link
Contributor

spillai commented Jun 13, 2023

Missing a rebase onto main

@spillai spillai force-pushed the sloftin/pyproject-excludes branch from 35e7a4c to 935c7e2 Compare June 13, 2023 02:55
@outtanames outtanames merged commit a320877 into main Jun 13, 2023
2 checks passed
@spillai spillai deleted the sloftin/pyproject-excludes branch July 7, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@outtanames @spillai