-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization bug #54
Comments
Thanks! I have new reporting almost rebuilt, which is now also more focused giving us access to details that are vital to the next level of abstraction i.e. optimizing the optimizing. Once we get the current dev to master, I'll add them to dev. What do you think about merging with master now? |
I think we could but if you’re refactoring Reporting we might as well wait until you’re done with that. Is there any reason to merge sooner? |
Ok great, yes I think it's good we merge now first. For reporting I'm actually writing it from scratch on the basis of what I found was useful. What do you think would be useful features to add in it? |
@mikkokotila Definitely a few things from my experience with it that I would recommend.
Can't think of anything else off the top of my head but yeah that's a good place to start! Let me know if there's anything I can do. Otherwise when you're done I'll try to help comment/cleanup and whatnot. 👍 |
@x94carbone thanks a lot. In terms of the callbacks, could you share some examples for the use-cases. Generally storing the history is of course easy, and it seems that the data size should be totally ok as long as we handle it in an array the right way during, and dump to the df only in the end of the process. For the displaying stuff I made the whole thing simpler in the way where you have a class object that takes in one parameter, which is the log, and then after that you have various properties (like peak round). Then it would be very easy to extend it. The code is super clean without any of the complexities of the current one. |
Nice, that sounds good. By callbacks do you just mean how I manipulate the dataframe to trim columns and that sort of thing? |
Well, in case that was what you were referring to, here's the answer. For the current state of Talos: First, if using a notebook, this will make the output easier for you to deal with.
Load the data you just ran using Talos, but suppress the output since it's not always going to be clearly formatted depending on some unknown factors.
Example of removing the columns in
Is this helpful? |
@channhan007 the whole reporting piece is going to be replaced with a new much cleaner approach that also supports the various use-cases including far better integration with plots. In the meantime for the simple table view, you might just use:
|
@mikkokotila Thank you for your response. I look at the csv output file and the column labels are not in the right order. I have to rearrange those column names. |
The new reporting is now included in dev. The old is removed, so closing here. Later we can have separate issues for new features for Reporting(). It's in /utils/reporting.py |
I noticed something with the
Reporting
class. I'm not sure ifreporting.data
is supposed to print cleanly, but it doesn't for me:The standard output looks like this
But I think an easy fix is to do this:
Thoughts?
The text was updated successfully, but these errors were encountered: