Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheriting the common configuration in modules #273

Closed
bartek-wesolowski opened this issue Sep 10, 2020 · 1 comment · Fixed by #278
Closed

Inheriting the common configuration in modules #273

bartek-wesolowski opened this issue Sep 10, 2020 · 1 comment · Fixed by #278
Labels
bug Something isn't working
Milestone

Comments

@bartek-wesolowski
Copy link

bartek-wesolowski commented Sep 10, 2020

When I declare the following configuration:

dependencyAnalysis {
    issues {
        all {
            onUsedTransitiveDependencies {
                severity('ignore')
            }
        }
        project(':lib') {
            onUnusedDependencies {
                exclude('some-dependency:to-exclude')
            }
        }
    }
}

I expect used transitive dependencies to be ignored in lib as well, but they aren't. If I declare a separate configuration for one of the modules, I have to copy the common configuration to the module configuration like this:

dependencyAnalysis {
    issues {
        all {
            onUsedTransitiveDependencies {
                severity('ignore')
            }
        }
        project(':lib') {
            onUnusedDependencies {
                exclude(
                    'some-dependency:to-exclude',
                )
            }
            onUsedTransitiveDependencies {
                severity('ignore')
            }
        }
    }
}

This is very inconvenient when you have 30+ modules and they all have to copy the configuration from issues.all when they declare their own configuration or excludes.

@autonomousapps
Copy link
Owner

I expect used transitive dependencies to be ignored in lib as well, but they aren't.

I expect that as well. Looks like you've found a bug (and thank you for the report). Would it be possible to provide a reproducer project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants