Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Kotlin 1.4 #333

Closed
plastiv opened this issue Nov 29, 2020 · 5 comments · Fixed by #343
Closed

Upgrade to Kotlin 1.4 #333

plastiv opened this issue Nov 29, 2020 · 5 comments · Fixed by #343
Labels
bug Something isn't working
Milestone
1.0

Comments

@plastiv
Copy link

plastiv commented Nov 29, 2020

Running plugin on a project with 1.4.20 kotlin results in an error

Caught an exception trying to connect to Kotlin Daemon:
java.lang.NoSuchMethodError: org.jetbrains.kotlin.cli.common.messages.MessageCollector$DefaultImpls.report$default(Lorg/jetbrains/kotlin/cli/common/messages/MessageCollector;Lorg/jetbrains/kotlin/cli/common/messages/CompilerMessageSeverity;Ljava/lang/String;Lorg/jetbrains/kotlin/cli/common/messages/CompilerMessageSourceLocation;ILjava/lang/Object;)V
        at org.jetbrains.kotlin.compilerRunner.KotlinCompilerRunnerUtils.newDaemonConnection(KotlinCompilerRunnerUtils.kt:83)
        at org.jetbrains.kotlin.compilerRunner.KotlinCompilerRunnerUtils.newDaemonConnection$default(KotlinCompilerRunnerUtils.kt:49)
        at org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner$Companion.getDaemonConnectionImpl$kotlin_gradle_plugin(GradleKotlinCompilerRunner.kt:187)
        at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.compileWithDaemon(GradleKotlinCompilerWork.kt:165)
        at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.compileWithDaemonOrFallbackImpl(GradleKotlinCompilerWork.kt:141)
        at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.run(GradleKotlinCompilerWork.kt:124)
        at org.gradle.workers.internal.AdapterWorkAction.execute(AdapterWorkAction.java:57)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:67)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:63)
        at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:97)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:63)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:62)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$call$2(DefaultBuildOperationExecutor.java:76)
        at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.callWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:54)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:76)
        at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:60)
        at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:200)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:215)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:164)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:131)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
        at java.lang.Thread.run(Thread.java:748)

Could not perform incremental compilation: Could not connect to Kotlin compile daemon
Could not connect to kotlin daemon. Using fallback strategy.

Running compilation without kotlin daemon results in a major performance slowdown. Is there any blocker for 1.4 upgrade?
@autonomousapps
Copy link
Owner

autonomousapps commented Nov 29, 2020 via email

@plastiv
Copy link
Author

plastiv commented Nov 30, 2020

Thank you for a quick response! I didn't had on top of my mind that gradle injects bundled kotlin (for kts) into plugins classpath. Seems like a valid reason, I shall wait then 👍

I think just using a project with latest android and latest kotlin will trigger an issue, will see if I can make a repro case based on integration tests at the repo.

@bvschaik
Copy link

bvschaik commented Dec 2, 2020

I'm also encountering this error. Version 0.66.0 introduced it, 0.65.0 and lower are unaffected. My project has been using Kotlin 1.4.20 for a while already in combination with 0.63.0 of this plugin so I'm not sure that the Kotlin version is to blame.

Minimum reproducing example:

  1. Use Android Studio 4.1.1
  2. Create a new project, use Kotlin (you'll get 1.4.20 by default), minimum api level 21, I chose "no activity"
  3. Add plugin to root build.gradle: 
    ...
buildscript {
    ...
    dependencies {
        ...
        classpath "com.autonomousapps:dependency-analysis-gradle-plugin:0.66.0"
    }
}
apply plugin: "com.autonomousapps.dependency-analysis"
...
  4. Run ./gradlew testDebugUnitTest from the command line and note the error reported in the issue scroll by.
  5. Downgrade to 0.65.0 of the plugin, run again and note the error is gone

@autonomousapps
Copy link
Owner

autonomousapps commented Dec 2, 2020 via email

@autonomousapps autonomousapps added this to the 1.0 milestone Dec 2, 2020
@autonomousapps autonomousapps added the bug Something isn't working label Dec 2, 2020
@autonomousapps autonomousapps mentioned this issue Dec 3, 2020
Merged
@autonomousapps
Copy link
Owner

Assuming this builds fine on CI, I will release v0.69.0 soon which will resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Don't use an enforced platform for the Kotlin BOM. autonomousapps/dependency-analysis-gradle-plugin
3 participants
@bvschaik @plastiv @autonomousapps