Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename advice$variant task to generateAdvice$variant (avoid ambiguity clash with assemble$variant) #476

Closed
jrodbx opened this issue Sep 16, 2021 · 3 comments · Fixed by #477
Labels
enhancement New feature or request
Milestone

Comments

@jrodbx
Copy link

jrodbx commented Sep 16, 2021

This could totally be a personal preference thing, but I use Gradle task name abbreviation alot, e.g.,

app:iD for app:installDebug, or
app:aD for app:assembleDebug

When applying this plugin, I get the following error when running app:aD:

Task 'aD' is ambiguous in project ':app'. Candidates are: 'adviceDebug', 'assembleDebug'.

Would it be possible to rename the task to something like generate${VARIANT}Advice to eliminate the conflict with the task provided by the Android Gradle Plugin?

@autonomousapps
Copy link
Owner

I can do this. I think it actually makes a lot of sense to generally avoid stepping on other very common tasks, such as assemble.... Is this the only one causing you trouble?

FWIW, I prefer generateAdvice$variant, because that's the format I use in all my other tasks. Does that work for you?

@autonomousapps autonomousapps added the enhancement New feature or request label Sep 16, 2021
@autonomousapps autonomousapps added this to the 1.0 milestone Sep 16, 2021
@autonomousapps autonomousapps changed the title Consider renaming advice task Rename advice$variant task to generateAdvice$variant (avoid ambiguity clash with assemble$variant) Sep 16, 2021
@jrodbx
Copy link
Author

jrodbx commented Sep 16, 2021

Is this the only one causing you trouble?

Yes.

FWIW, I prefer generateAdvice$variant, because that's the format I use in all my other tasks. Does that work for you?

For sure. My suggestion was going by AGP-style but i don't have any opinion either way.

@autonomousapps
Copy link
Owner

Cool, thanks for confirming. I fixed this in the associated PR. You can already use it with a snapshot, but you can also wait for the next release (0.78.0), which is probably today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants