Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR Understand proguard-only projects #13

Open
ZacSweers opened this issue Dec 26, 2019 · 3 comments
Open

FR Understand proguard-only projects #13

ZacSweers opened this issue Dec 26, 2019 · 3 comments
Labels
enhancement New feature or request toolchain:android

Comments

@ZacSweers
Copy link
Sponsor Contributor

Some projects contain only proguard files used by AGP. Example: https://github.com/artem-zinnatullin/RxJavaProGuardRules

Might be tricky as other "unused" projects would still have their proguard files being used. I think a reasonable middle ground is to only ignore them if they only have proguard files included and nothing else.

Alternatively could be handled by an exclusion extension of some sort

@autonomousapps autonomousapps added this to the 1.0 milestone May 11, 2020
@autonomousapps
Copy link
Owner

Added a 1.0 milestone. This issue is important enough that I consider it a prereq for 1.0 status.

@ZacSweers
Copy link
Sponsor Contributor Author

edit - only applicable to android application projects really

@autonomousapps autonomousapps modified the milestones: 1.0, 1.1 Jun 1, 2020
@autonomousapps
Copy link
Owner

@ZacSweers you said

I think a reasonable middle ground is to only ignore them if they only have proguard files included and nothing else.

Whereas I was thinking, if a project only contains proguard rules, always consider it used. Or am I misunderstanding you?

Relatedly, if a project only contains proguard rules, could it be compileOnly? Or if that doesn't work, releaseImplementation instead of implementation? (since it is only relevant on build types where minifyEnabled is true.)

@autonomousapps autonomousapps modified the milestones: 1.1, 2.0 Sep 7, 2021
@autonomousapps autonomousapps modified the milestones: 2.0, 1.1 Mar 26, 2022
@autonomousapps autonomousapps removed this from the 1.1 milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request toolchain:android
Projects
None yet
Development

No branches or pull requests

2 participants