Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recommend adding direct dependencies if they're only used by generated code? #48

Closed
autonomousapps opened this issue Jan 24, 2020 · 4 comments · Fixed by #158
Closed

Don't recommend adding direct dependencies if they're only used by generated code? #48

autonomousapps opened this issue Jan 24, 2020 · 4 comments · Fixed by #158
Labels
enhancement New feature or request
Milestone
1.0

Comments

@autonomousapps
Copy link
Owner

No description provided.

@autonomousapps
Copy link
Owner Author

For example, I think that org.jetbrains:annotations is either added by the Kotlin plugin or brought in transitively, and in either case does not appear in source. Added to generated code or only present in bytecode (added by kotlinc).

@autonomousapps autonomousapps mentioned this issue Mar 5, 2020
Closed
@ZacSweers
Copy link
Sponsor Contributor

Examples:

  • Annotated by @Generated
  • In a package containing .generated
  • Under the build dir

@autonomousapps autonomousapps added the enhancement New feature or request label May 11, 2020
@autonomousapps autonomousapps added this to the 1.0 milestone May 11, 2020
@autonomousapps
Copy link
Owner Author

Added a 1.0 milestone. This issue is important enough that I consider it a prereq for 1.0 status.

@ZacSweers
Copy link
Sponsor Contributor

Related - a .generated support would need to be a custom package exclusion, which also opens up excluding .internal (another convention)

@ZacSweers ZacSweers mentioned this issue May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Support ABI exclusions
2 participants
@ZacSweers @autonomousapps