Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError #1

Closed
ytuza opened this issue Dec 19, 2020 · 1 comment
Closed

ArgumentError #1

ytuza opened this issue Dec 19, 2020 · 1 comment

Comments

@ytuza
Copy link

ytuza commented Dec 19, 2020

parser.add_argument("--N_samples", type=int, default=32*32*4, help='batch size (number of random rays per gradient step)')

The argument is duplicated, and causes an error
It should be
parser.add_argument ("- N_rand", type = int, default = 32 * 32 * 4, help = 'batch size (number of random rays per gradient step)')

@katjaschwarz
Copy link
Collaborator

That's true, thanks! I fixed it in the file.
It should not cause an error in the main code though, as we only use the modified version of this file (run_nerf_mod.py). The other file is just included for completness of the submodule. Please refer to the original repo https://github.com/yenchenlin/nerf-pytorch for the latest version of the submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants