Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about fine vs coarse raysampling #10

Closed
ebartrum opened this issue May 4, 2021 · 2 comments
Closed

Question about fine vs coarse raysampling #10

ebartrum opened this issue May 4, 2021 · 2 comments

Comments

@ebartrum
Copy link

ebartrum commented May 4, 2021

Hey,
My impression from reading the paper was that the coarse then fine raysampling steps are performed on the same implicit function in order to sample in areas of higher alpha density for this function. However, my understanding from reading the code is that generator and generator fine have 2 separate implicit functions with different parameters. Could you clarify which of these is correct? As far as I understand, only the output from generator fine is used to compute the loss.

@ebartrum
Copy link
Author

Or is it that you only use the coarse ray sample, because in default.yaml N_importance is set to 0?

@katjaschwarz
Copy link
Collaborator

Yes, we only used coarse ray sampling to reduce the amount of required memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants