Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about tweaking MSLyncURLandUpdateInfoProvider.py #33

Closed
jbaker10 opened this issue Jan 9, 2016 · 2 comments
Closed

Question about tweaking MSLyncURLandUpdateInfoProvider.py #33

jbaker10 opened this issue Jan 9, 2016 · 2 comments

Comments

@jbaker10
Copy link
Contributor

jbaker10 commented Jan 9, 2016

Allister,

I was wondering if you would be open to a PR to very slightly change the MSLyncURLandUpdateInfoProvider.py processor you have written for Lync. The update would just declare one more output variable, display_name, which would give the nicely formatted name of Lync 14.2.x Update as opposed to what we currently have to use, which is just Lync Installer.pkg. This poses an issue for us using the AbsoluteManageExport processor as it compares pkg names to that in the DB, and if it already exists, it assumes the pkg isn't new S.ice the pkg name is always Lync Installer.pkg, it never imports into AbMan. This new output variable would alleviate that by allowing us to rename the pkg in our .absolute recipe to be the %display_name% instead which would then change upon new updates.

I have the code updated, I believe its a total of about 5 new lines. Let me know your thoughts and I can submit a PR.

Thanks!

@arubdesu
Copy link
Member

arubdesu commented Jan 9, 2016

Yes, please

@jbaker10
Copy link
Contributor Author

Thanks! Just tested in prod and all is working well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants