Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopkg 0.2.5 fails under 10.6.8 #61

Closed
henningkessler opened this issue Jan 6, 2014 · 12 comments
Closed

Autopkg 0.2.5 fails under 10.6.8 #61

henningkessler opened this issue Jan 6, 2014 · 12 comments

Comments

@henningkessler
Copy link

Hi,

i tried the 0.2.5. release unter two 10.6.8 server installations and both failed.

vmserver:RecipeOverrides virt$ autopkg list-recipes
Traceback (most recent call last):
File "/usr/local/bin/autopkg", line 1247, in
sys.exit(main(sys.argv))
File "/usr/local/bin/autopkg", line 1241, in main
exit(subcommands[verb]'function')
File "/usr/local/bin/autopkg", line 848, in list_recipes
if valid_recipe(match):
File "/usr/local/bin/autopkg", line 102, in valid_recipe
return (valid_plist_with_keys(filename, ["Input", "Process"])
File "/usr/local/bin/autopkg", line 88, in valid_plist_with_keys
recipe_plist = FoundationPlist.readPlist(filename)
File "/Library/AutoPkg/FoundationPlist/FoundationPlist.py", line 72, in readPlist
plistData, NSPropertyListMutableContainersAndLeaves, None, None))
ValueError: too many values to unpack

@gregneagle
Copy link
Contributor

It's possible that some recent changes to FoundationPlist broke compatibility with 10.6.x. I'll test later today when I have access to a 10.6.8 machine.

-Greg

On Jan 6, 2014, at 5:02 AM, henningkessler notifications@github.com wrote:

Hi,

i tried the 0.2.5. release unter two 10.6.8 server installations and both failed.

vmserver:RecipeOverrides virt$ autopkg list-recipes
Traceback (most recent call last):
File "/usr/local/bin/autopkg", line 1247, in
sys.exit(main(sys.argv))
File "/usr/local/bin/autopkg", line 1241, in main
exit(subcommands[verb]'function')
File "/usr/local/bin/autopkg", line 848, in list_recipes
if valid_recipe(match):
File "/usr/local/bin/autopkg", line 102, in valid_recipe
return (valid_plist_with_keys(filename, ["Input", "Process"])
File "/usr/local/bin/autopkg", line 88, in valid_plist_with_keys
recipe_plist = FoundationPlist.readPlist(filename)
File "/Library/AutoPkg/FoundationPlist/FoundationPlist.py", line 72, in readPlist
plistData, NSPropertyListMutableContainersAndLeaves, None, None))
ValueError: too many values to unpack


Reply to this email directly or view it on GitHub.

@gregneagle
Copy link
Contributor

I can reproduce this issue on 10.6.8.

-Greg

On Jan 6, 2014, at 7:24 AM, Gregory Neagle gregneagle@mac.com wrote:

It's possible that some recent changes to FoundationPlist broke compatibility with 10.6.x. I'll test later today when I have access to a 10.6.8 machine.

-Greg

On Jan 6, 2014, at 5:02 AM, henningkessler notifications@github.com wrote:

Hi,

i tried the 0.2.5. release unter two 10.6.8 server installations and both failed.

vmserver:RecipeOverrides virt$ autopkg list-recipes
Traceback (most recent call last):
File "/usr/local/bin/autopkg", line 1247, in
sys.exit(main(sys.argv))
File "/usr/local/bin/autopkg", line 1241, in main
exit(subcommands[verb]'function')
File "/usr/local/bin/autopkg", line 848, in list_recipes
if valid_recipe(match):
File "/usr/local/bin/autopkg", line 102, in valid_recipe
return (valid_plist_with_keys(filename, ["Input", "Process"])
File "/usr/local/bin/autopkg", line 88, in valid_plist_with_keys
recipe_plist = FoundationPlist.readPlist(filename)
File "/Library/AutoPkg/FoundationPlist/FoundationPlist.py", line 72, in readPlist
plistData, NSPropertyListMutableContainersAndLeaves, None, None))
ValueError: too many values to unpack


Reply to this email directly or view it on GitHub.

@henningkessler
Copy link
Author

Good to know, is there a chance that autopkg will continue to support 10.6.8 or could this be a point where support will be dropped?

Henning

Am 06.01.2014 um 17:08 schrieb Greg Neagle notifications@github.com:

I can reproduce this issue on 10.6.8.

-Greg

On Jan 6, 2014, at 7:24 AM, Gregory Neagle gregneagle@mac.com wrote:

It's possible that some recent changes to FoundationPlist broke compatibility with 10.6.x. I'll test later today when I have access to a 10.6.8 machine.

-Greg

On Jan 6, 2014, at 5:02 AM, henningkessler notifications@github.com wrote:

Hi,

i tried the 0.2.5. release unter two 10.6.8 server installations and both failed.

vmserver:RecipeOverrides virt$ autopkg list-recipes
Traceback (most recent call last):
File "/usr/local/bin/autopkg", line 1247, in
sys.exit(main(sys.argv))
File "/usr/local/bin/autopkg", line 1241, in main
exit(subcommands[verb]'function')
File "/usr/local/bin/autopkg", line 848, in list_recipes
if valid_recipe(match):
File "/usr/local/bin/autopkg", line 102, in valid_recipe
return (valid_plist_with_keys(filename, ["Input", "Process"])
File "/usr/local/bin/autopkg", line 88, in valid_plist_with_keys
recipe_plist = FoundationPlist.readPlist(filename)
File "/Library/AutoPkg/FoundationPlist/FoundationPlist.py", line 72, in readPlist
plistData, NSPropertyListMutableContainersAndLeaves, None, None))
ValueError: too many values to unpack


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@gregneagle
Copy link
Contributor

We're not doing a lot of testing on 10.6 since that's three major OS releases ago. And no testing at all on 10.5.

-Greg

On Jan 6, 2014, at 8:11 AM, henningkessler notifications@github.com wrote:

Good to know, is there a chance that autopkg will continue to support 10.6.8 or could this be a point where support will be dropped?

Henning

Am 06.01.2014 um 17:08 schrieb Greg Neagle notifications@github.com:

I can reproduce this issue on 10.6.8.

-Greg

On Jan 6, 2014, at 7:24 AM, Gregory Neagle gregneagle@mac.com wrote:

It's possible that some recent changes to FoundationPlist broke compatibility with 10.6.x. I'll test later today when I have access to a 10.6.8 machine.

-Greg

On Jan 6, 2014, at 5:02 AM, henningkessler notifications@github.com wrote:

Hi,

i tried the 0.2.5. release unter two 10.6.8 server installations and both failed.

vmserver:RecipeOverrides virt$ autopkg list-recipes
Traceback (most recent call last):
File "/usr/local/bin/autopkg", line 1247, in
sys.exit(main(sys.argv))
File "/usr/local/bin/autopkg", line 1241, in main
exit(subcommands[verb]'function')
File "/usr/local/bin/autopkg", line 848, in list_recipes
if valid_recipe(match):
File "/usr/local/bin/autopkg", line 102, in valid_recipe
return (valid_plist_with_keys(filename, ["Input", "Process"])
File "/usr/local/bin/autopkg", line 88, in valid_plist_with_keys
recipe_plist = FoundationPlist.readPlist(filename)
File "/Library/AutoPkg/FoundationPlist/FoundationPlist.py", line 72, in readPlist
plistData, NSPropertyListMutableContainersAndLeaves, None, None))
ValueError: too many values to unpack


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@henningkessler
Copy link
Author

I thought so. But 10.7 & 10.8 server releases had been to buggy or had missing features like LACP support. Upgrade to 10.9 is planned later this year. Until that support for 10.6.8 would be great (shame)

Henning

Am 06.01.2014 um 17:13 schrieb Greg Neagle notifications@github.com:

We're not doing a lot of testing on 10.6 since that's three major OS releases ago. And no testing at all on 10.5.

-Greg

@gregneagle
Copy link
Contributor

autopkg doesn't have to run on a server!

We'll try to maintain 10.6.8 compatibility, but as I said, we don't do a lot of testing there.

-Greg

On Jan 6, 2014, at 8:27 AM, henningkessler notifications@github.com wrote:

I thought so. But 10.7 & 10.8 server releases had been to buggy or had missing features like LACP support. Upgrade to 10.9 is planned later this year. Until that support for 10.6.8 would be great (shame)

Henning

Am 06.01.2014 um 17:13 schrieb Greg Neagle notifications@github.com:

We're not doing a lot of testing on 10.6 since that's three major OS releases ago. And no testing at all on 10.5.

-Greg

Reply to this email directly or view it on GitHub.

@henningkessler
Copy link
Author

Am 06.01.2014 um 17:39 schrieb Greg Neagle notifications@github.com:

autopkg doesn't have to run on a server!
Yes i know, but the both servers are the only constantly running machines on that site.

We'll try to maintain 10.6.8 compatibility, but as I said, we don't do a lot of testing there.
That's great, and i don't mind encounter issues as I know that those servers run an ancient OS.

I am very very appreciating your guys work

Henning

@gregneagle
Copy link
Contributor

I believe this has been addressed here: 90b7a21

Please test with a version from the Git repo and let us know.

@henningkessler
Copy link
Author

Hi Greg,

yes, you are right. AutoPkg 0.2.6. is working now under 10.6.8.

Thank you very much.

Henning

Am 06.01.2014 um 19:57 schrieb Greg Neagle notifications@github.com:

I believe this has been addressed here: 90b7a21

Please test with a version from the Git repo and let us know.


Reply to this email directly or view it on GitHub.

@timsutton
Copy link
Member

I just ran a recipe with a plist formatting error and it happened to catch this bug since this was refactored:

~/git/github/autopkg/Code/autopkg run -vv Dropbox.munki
Traceback (most recent call last):
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 1247, in <module>
    sys.exit(main(sys.argv))
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 1241, in main
    exit(subcommands[verb]['function'](argv))
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 1035, in run_recipes
    recipe = load_recipe(recipe_path, override_dirs, search_dirs)
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 231, in load_recipe
    name, override_dirs + recipe_dirs)
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 150, in find_recipe_by_identifier
    if get_identifer_from_recipe_file(match) == identifier:
  File "/Users/tsutton/git/github/autopkg/Code/autopkg", line 131, in get_identifer_from_recipe_file
    recipe_plist = FoundationPlist.readPlist(filename)
  File "/Users/tsutton/git/github/autopkg/Code/FoundationPlist/FoundationPlist.py", line 112, in readPlist
    return _dataToPlist(data)
  File "/Users/tsutton/git/github/autopkg/Code/FoundationPlist/FoundationPlist.py", line 84, in _dataToPlist
    errmsg = u"%s in file %s" % (error, filepath)
NameError: global name 'filepath' is not defined

@timsutton timsutton reopened this Jan 7, 2014
@gregneagle
Copy link
Contributor

Try this: a6be44c

@timsutton
Copy link
Member

Worked great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants