Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for wells_with to add support for non-str values #193

Merged
merged 3 commits into from Apr 19, 2019
Merged

Conversation

yangchoo
Copy link
Contributor

We added support for non-str values in properties as part of PR190. We did not update wells_with and this adds in the missing support.

Copy link
Contributor

@joshhacksthings joshhacksthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would you mind adding a few more container_tests that include testing properties with values that include:

  • Booleans
  • Floats

That would cover the types that apps currently uses in ali props

@joshhacksthings joshhacksthings self-requested a review April 19, 2019 19:04
@joshhacksthings
Copy link
Contributor

I also want to add a comment here that TX's internal infrastructure (WEB) prohibits the use of anything except for a String type as a value for a property...

Copy link
Contributor

@joshhacksthings joshhacksthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
good catch on container.py/429 --> "if val is not None"

@yangchoo yangchoo merged commit a33aeb5 into master Apr 19, 2019
@yangchoo yangchoo deleted the fix-wells-with branch April 19, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants