add seal capability to 384-flat #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VarunKanwar could you review this and approve this merge? thanks! |
|
It would be great if you could set the terribly named In the long-term I think we should eliminate these implicit cover/seal steps but for now we should keep this backwards compatible. |
|
@rhysormond made the changes, let me know if there's anything else. I saw that tx also update the changelog, not sure if I should do that though |
fix test handling fix parentheses
danielwenwen
force-pushed
the
daniel-make-384-flat-sealable
branch
from
76b2109
to
681be55
Compare
VarunKanwar
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.