Fix well_from_shape bug #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
well_from_shape was not returning correct wells for index beyond one. For example, for a 384 well with origin well of A2 and shape of 96 well to select, it should return the 2nd quadrant, however, the current code returns the 1st quadrant wells. This commit adds the tests and shows the test are failing.
|
cc @gasnew |
yaoyuyang
commented
Jan 24, 2020
rhysormond
previously approved these changes
Jan 27, 2020
rhysormond
previously approved these changes
Jan 27, 2020
yaoyuyang
force-pushed
the
fix-well-from-shape-bug
branch
from
73ad843
to
7752b81
Compare
rhysormond
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well_from_shape was not returning correct wells for index beyond one.
For example, for a 384 well with origin well of A2 and shape of 96 well
to select, it should return the 2nd quadrant, however, the current code
returns the 1st quadrant wells. We added failing tests and fixed this bug
by using a new approach for calculating well indices and checking boundaries.