build: pre-commit infrastructure and update travis #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangchoo
force-pushed
the
add-pre-commit
branch
3 times, most recently
from
70fdfae
to
3ecdab5
Compare
|
Please do check out the Travis build for the new test matrix: https://travis-ci.org/github/autoprotocol/autoprotocol-python/builds/689570208 |
rhysormond
previously approved these changes
May 21, 2020
| - python: '3.6' | ||
| env: TOXENV=lint | ||
| - python: '3.6' | ||
| env: TOXENV=clean,py36,stats |
There was a problem hiding this comment.
is the clean step here necessary still?
There was a problem hiding this comment.
ah, yea, its to blow away coverage artifacts if present. It seems common in other travis integration libraries, so I assume its doing something but haven't validated
|
somewhat related, can we configure travis so that it's using something newer than xenial? |
|
yea, could use Bionic (https://docs.travis-ci.com/user/reference/linux/). It shouldn't really matter since we're using mostly pip/tox for the running, so it should be fine to upgrade. I'll try it |
Add pre-commit infrastructure to help with basic lint tasks. This is in preparation of adding an autoformatter for the repo. As part of this, the travis file is reorganized to help with clearer delineation of jobs. Documention is also updated, with the Contributing section updated with more explicit testing steps and the new environment and lint setup. This includes all the fixes from the pre-commit hooks added.
rhysormond
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit infrastructure to help with basic lint tasks. This is in
preparation of adding an autoformatter for the repo.
As part of this, the travis file is reorganized to help with clearer
delineation of jobs.
Documention is also updated, with the Contributing section updated with
more explicit testing steps and the new environment and lint setup.
This includes all the fixes from the pre-commit hooks added.