Propagate aliquot properties bug #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to the the method that Protocol.propagate_properties uses to propagate properties, solved internal Strateos issues when overwriting an aliquot property key. The main issue is the warning caused by overwriting keys is sent to stdout which prevents the building and and execution of the protocol on the Strateos Web app. However, the change breaks Ginkgo's expectation of how the properties are propagated. This PR reverts the method used back to the original
.add_propertiesmethod. Since the original bug only is seen internally in a very specific edge case.