enable 384 reservoir stamping if indicated in container_type.capabilities #300
Conversation
…ties via keyword sbs384_compatible
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 20 20
Lines 3803 3803
=======================================
Hits 3123 3123
Misses 680 680
Continue to review full report at Codecov.
|
|
See former (now closed) pull request to compare different implementations: |
| if ( | ||
| shape["format"] == "SBS384" | ||
| and container_wells < 384 | ||
| and "sbs384_compatible" not in container_type.capabilities |
There was a problem hiding this comment.
container type capabilities are usually the names of the operations/instructions that can be performed on a container type. sbs384_compatible will never be found in the container_type.capabilities unfortunately.
There was a problem hiding this comment.
@EribertoLopez In my other feature branch I added an is_reservoir attribute to the container_type dictionary with default of false to be set to true when writing client protocols. This approach above is per Vanessa's suggestion: https://github.com/autoprotocol/autoprotocol-python/pull/299#discussion_r621251956
In light of these two approaches, do you have an alternative idea?
There was a problem hiding this comment.
And thanks for the feedback!
autoprotocol/container_type.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| :license: BSD, see LICENSE for more details | |||
|
|
|||
| """ | |||
|
|
|||
| # fmt: off | |||
There was a problem hiding this comment.
why are you turning off the Black formatter here? Don't like it? 🙈
There was a problem hiding this comment.
Oh whoops, I'll fix that haha
test/util_test.py
Outdated
| # fmt: off | ||
| # pylint: disable=W0703 |
There was a problem hiding this comment.
why are you turning black and pylint off?
Instead of adding is_reservoir attribute, use the container_type.capabilities list to verify if plate is compatible with SBS384 transfers despite not having 384 wells.
7.9.0 <2021-05-18>301Allow reservoir stamping for plates with shape SBS384 provided that container has capability:sbs384_compatible. Capability added to container RESSW384LP.294Add tests in util to check if container type is a compatible reservoirPlease Land this PR after the stdv-665 port liquid_handle_dispense pr to respect versioning.
link to task