New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stdv 665 port liquid handle dispense #301
Stdv 665 port liquid handle dispense #301
Conversation
py to appy
…ams, add protein buffer to list of liquid classes and add vol resolution param
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 81.77% 82.11% +0.34%
==========================================
Files 19 20 +1
Lines 3688 3803 +115
==========================================
+ Hits 3016 3123 +107
- Misses 672 680 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, some comments, all around good stuff.
- remove
txappy
references - change
appy
->autoprotocol
- alphabetize author list by last name
- discuss
liquid_handle_dispense
method-specific tests and where they should live with me
…est of lhd tests to separate test file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Link to Jira Task
Link to txappy pr where corresponding code is removed