Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdv 665 port liquid handle dispense #301

Merged
merged 15 commits into from May 20, 2021

Conversation

aaronkarlsberg1
Copy link
Collaborator

@aaronkarlsberg1 aaronkarlsberg1 commented May 17, 2021

  • Port liquid_handle_dispense method (tempest) from txappy to appy
  • Expand LiquidHandleBuilders class to account for protein buffer liquid class and volume resolution
  • Helper function for building device level mode_params in LiquidHandleBuilders for tempest
  • Add tests for liquid_handle_dispense method
  • Update authors

Link to Jira Task

Link to txappy pr where corresponding code is removed

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #301 (a8778c7) into master (c55ed94) will increase coverage by 0.34%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   81.77%   82.11%   +0.34%     
==========================================
  Files          19       20       +1     
  Lines        3688     3803     +115     
==========================================
+ Hits         3016     3123     +107     
- Misses        672      680       +8     
Impacted Files Coverage Δ
autoprotocol/version.py 0.00% <0.00%> (ø)
autoprotocol/liquid_handle/dispense.py 90.56% <90.56%> (ø)
autoprotocol/protocol.py 77.62% <95.00%> (+0.49%) ⬆️
autoprotocol/builders.py 85.50% <95.45%> (+0.30%) ⬆️
autoprotocol/liquid_handle/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55ed94...a8778c7. Read the comment docs.

Copy link
Contributor

@joshhacksthings joshhacksthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, some comments, all around good stuff.

  • remove txappy references
  • change appy -> autoprotocol
  • alphabetize author list by last name
  • discuss liquid_handle_dispense method-specific tests and where they should live with me

AUTHORS.rst Outdated Show resolved Hide resolved
autoprotocol/builders.py Outdated Show resolved Hide resolved
autoprotocol/builders.py Outdated Show resolved Hide resolved
autoprotocol/builders.py Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
autoprotocol/protocol.py Outdated Show resolved Hide resolved
autoprotocol/protocol.py Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
test/liquid_handle_unit_test.py Outdated Show resolved Hide resolved
aaronstrateos added 2 commits May 20, 2021 14:47
Copy link
Contributor

@joshhacksthings joshhacksthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@aaronkarlsberg1 aaronkarlsberg1 merged commit 948fca5 into master May 20, 2021
@aaronkarlsberg1 aaronkarlsberg1 deleted the stdv-665-port-liquid-handle-dispense branch May 20, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants