Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor the githubrelease module #42

Open
justinmayer opened this issue Feb 2, 2024 · 0 comments · May be fixed by #43
Open

Vendor the githubrelease module #42

justinmayer opened this issue Feb 2, 2024 · 0 comments · May be fixed by #43

Comments

@justinmayer
Copy link
Collaborator

justinmayer commented Feb 2, 2024

The current shipped githubrelease package on PyPI is lacking a fix for a problem affecting the use of implicitly-populated GITHUB_TOKEN environment variables. To be clear, the problem is already fixed via scikit-build/github-release#73 but isn't yet available in a shipped release on PyPI.

Moreover, there is a problem with that project's setup.py configuration that prevents installing directly from the githubrelease repository's master branch. Related PR: scikit-build/github-release#76

After thinking of the many hours I have spent dealing with this issue as well as other problems related to githubrelease, I am currently of the mind that we should vendor this module inside AutoPub. That would give us agency and direct control over its behavior, without having to be reliant on the upstream project.

Related discussion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant