Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotplug_mem_share_discard_data: new auto case for memory hotplug with share and discard-data options #3349

Merged
merged 1 commit into from Aug 8, 2022
Merged

hotplug_mem_share_discard_data: new auto case for memory hotplug with share and discard-data options #3349

merged 1 commit into from Aug 8, 2022

Conversation

mcasquer
Copy link
Contributor

@mcasquer mcasquer commented Jun 8, 2022 •
edited

hotplug_mem_share_discard_data: new memory auto case
hotplug with share and discard-data options

Creates a new auto case that setup hugeapages, boots a guest with a
memory-backend-file object and one numa node, hotplugs backend-ram
or backend-file memory object with share: True option and the first one
could be with discard-data on/off, then checks the plugged memory device,
unplugs it and check results for discard-data value

ID: 2095232
Signed-off-by: mcasquer mcasquer@redhat.com

@mcasquer mcasquer force-pushed the 2030525_new_auto_case branch 3 times, most recently from f529f60 to cc764ed Compare June 8, 2022 06:56
@mcasquer
Copy link
Contributor Author

mcasquer commented Jun 8, 2022

@yanan-fu please could you review this PR? Thanks!

@mcasquer mcasquer force-pushed the 2030525_new_auto_case branch 2 times, most recently from 93baaef to 204117d Compare June 8, 2022 07:03
@mcasquer
Copy link
Contributor Author

mcasquer commented Jun 8, 2022

JOB ID : 4c62354a536f4eeda411424fc9c5a67dbfddcd6a
JOB LOG : /root/avocado/job-results/job-2022-06-08T03.50-4c62354/job.log
(1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: STARTED
(1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: PASS (54.32 s)
(2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: STARTED
(2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: PASS (54.39 s)
(3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: STARTED
(3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: PASS (55.40 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado/job-results/job-2022-06-08T03.50-4c62354/results.html
JOB TIME : 166.91 s

yanan-fu
yanan-fu reviewed Jun 16, 2022
View reviewed changes
qemu/tests/cfg/hotplug_mem_share_discard_data.cfg Outdated Show resolved Hide resolved
qemu/tests/cfg/hotplug_mem_share_discard_data.cfg Outdated Show resolved Hide resolved
qemu/tests/cfg/hotplug_mem_share_discard_data.cfg Outdated Show resolved Hide resolved
qemu/tests/hotplug_mem_share_discard_data.py Outdated Show resolved Hide resolved
@mcasquer mcasquer force-pushed the 2030525_new_auto_case branch 4 times, most recently from bdc29c8 to 697807b Compare June 22, 2022 07:27
@mcasquer
Copy link
Contributor Author

(1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: STARTED
(1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: PASS (45.64 s)
(2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: STARTED
(2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: PASS (44.88 s)
(3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: STARTED
(3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: PASS (45.34 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@mcasquer
Copy link
Contributor Author

@yanan-fu could you review this PR? Thanks !

@yanan-fu
Copy link
Contributor

@MiriamDeng @zhenyzha @fbq815 Could you please help review from ppc, aarch64, s390x side ? Thanks!

@fbq815
Copy link
Contributor

fbq815 commented Jun 29, 2022

@MiriamDeng @zhenyzha @fbq815 Could you please help review from ppc, aarch64, s390x side ? Thanks!

we don't support memory-unplug and NUMA on s390x right now, I cannot get this test case a PASS

@yanan-fu
Copy link
Contributor

@MiriamDeng @zhenyzha @fbq815 Could you please help review from ppc, aarch64, s390x side ? Thanks!

we don't support memory-unplug and NUMA on s390x right now, I cannot get this test case a PASS

@mcasquer Based on the info above, no s390x is needed.

@mcasquer
Copy link
Contributor Author

@MiriamDeng @zhenyzha @fbq815 Could you please help review from ppc, aarch64, s390x side ? Thanks!

we don't support memory-unplug and NUMA on s390x right now, I cannot get this test case a PASS

@mcasquer Based on the info above, no s390x is needed.

@yanan-fu
Got it. And what about my comment of the qemu-kvm version?

@MiriamDeng
Copy link
Contributor

It failed on ppc64le
[stdlog] File "/root/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-qemu/qemu/tests/hotplug_mem_share_discard_data.py", line 60, in run
[stdlog] hotplug_test.check_memory(vm)
[stdlog] File "/home/kar/workspace/avocado-vt/virttest/error_context.py", line 135, in new_fn
[stdlog] return fn(*args, **kwargs)
[stdlog] File "/home/kar/workspace/avocado-vt/virttest/utils_test/qemu/init.py", line 737, in check_memory
[stdlog] raise exceptions.TestFail(msg)
[stdlog] avocado.core.exceptions.TestFail: Assigned '5120 MB' memory to 'avocado-vt-vm1'but, '4541 MB' memory detect by OS

@mcasquer mcasquer force-pushed the 2030525_new_auto_case branch 3 times, most recently from 292eceb to e73923d Compare August 2, 2022 11:13
@mcasquer
Copy link
Contributor Author

mcasquer commented Aug 2, 2022

@yanan-fu could you review this PR? I don't know why checks have failed, they are not related with changed code... 😕

@yanan-fu
Copy link
Contributor

yanan-fu commented Aug 3, 2022

@yanan-fu could you review this PR? I don't know why checks have failed, they are not related with changed code... confused

Refer: #3421
Right, not related with this patch, we can repush after the patch above be merged.

@mcasquer
Copy link
Contributor Author

mcasquer commented Aug 3, 2022

@yanan-fu Repushed, could you review the PR? Thanks!

yanan-fu
yanan-fu reviewed Aug 3, 2022
View reviewed changes
qemu/tests/hotplug_mem_share_discard_data.py Outdated Show resolved Hide resolved
qemu/tests/hotplug_mem_share_discard_data.py Outdated Show resolved Hide resolved
qemu/tests/hotplug_mem_share_discard_data.py Outdated Show resolved Hide resolved
@mcasquer
Copy link
Contributor Author

mcasquer commented Aug 3, 2022

qemu-kvm-6.0.0-13

 (1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: STARTED
 (1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: CANCEL: Got host qemu version:6.0.0-13, which is not in [6.1.0, ) (5.20 s)
 (2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: STARTED
 (2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: PASS (68.17 s)
 (3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: STARTED
 (3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: PASS (72.53 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1

qemu-kvm-7.0.0-9

 (1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: STARTED
 (1/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.q35: PASS (73.78 s)
 (2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: STARTED
 (2/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.q35: PASS (73.69 s)
 (3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: STARTED
 (3/3) Host_RHEL.m9.u1.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.x86_64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.q35: PASS (72.36 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@mcasquer mcasquer force-pushed the 2030525_new_auto_case branch 3 times, most recently from 972dcdd to f2fcb50 Compare August 3, 2022 10:59
@yanan-fu
Copy link
Contributor

yanan-fu commented Aug 3, 2022

@zhenyzha @MiriamDeng As big change be added after your test, could you please check and share the test result with the latest code ? Thanks!

@zhenyzha
Copy link
Contributor

zhenyzha commented Aug 5, 2022 

 (1/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.arm64-pci: STARTED
 (1/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram.arm64-pci: PASS (128.97 s)
 (2/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.arm64-pci: STARTED
 (2/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on.arm64-pci: PASS (111.71 s)
 (3/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.arm64-pci: STARTED
 (3/3) Host_RHEL.m9.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.1.0.aarch64.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off.arm64-pci: PASS (112.40 s)

ack

@MiriamDeng
Copy link
Contributor

Others LGTM
(1/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram: STARTED
(1/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_ram: PASS (98.23 s)
(2/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on: STARTED
(2/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_on: PASS (104.19 s)
(3/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off: STARTED
(3/3) Host_RHEL.m8.u7.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.7.0.ppc64le.io-github-autotest-qemu.hotplug_mem_share_discard_data.backend_file.discard_data_off: PASS (105.44 s)

@mcasquer
Copy link
Contributor Author

mcasquer commented Aug 8, 2022

@yanan-fu could you review this PR?

@mcasquer
hotplug_mem_share_discard_data: new memory auto case
26dda47 
hotplug with share and discard-data options

Signed-off-by: mcasquer <mcasquer@redhat.com>
yanan-fu
yanan-fu approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@yanan-fu yanan-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@yanan-fu
Copy link
Contributor

yanan-fu commented Aug 8, 2022

Thanks all!

@yanan-fu yanan-fu merged commit 0b92966 into autotest:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamDeng MiriamDeng MiriamDeng left review comments

@zhenyzha zhenyzha zhenyzha approved these changes

@yanan-fu yanan-fu yanan-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcasquer @yanan-fu @fbq815 @MiriamDeng @zhenyzha