installer: start virtiofs after reboot guest #3578
Conversation
For some guests, need to restart os after updating drivers. And after os rebooted, need to start virtiofs service. Signed-off-by: Xiaoling Gao <xiagao@redhat.com>
xiagao
force-pushed
the
bz2156859-installer
branch
from
f8f5add
to
8bc03c0
Compare
|
@leidwang @YongxueHong Call for your review,thanks. |
| @@ -109,12 +109,13 @@ def change_virtio_media(cdrom_virtio): | |||
| installer_pkg_check_cmd, | |||
| copy_files_params=params) | |||
|
|
|||
| error_context.context("Run viofs service after upgrade...") | |||
| win_driver_installer_test.run_viofs_service(test, params, session) | |||
|
|
|||
There was a problem hiding this comment.
Hi @xiagao Why we need to remove these 2 line?Seems we only need to add run_viofs_service after vm reboot.
There was a problem hiding this comment.
I did't remove, pls look at the following lines,just move it below.
There was a problem hiding this comment.
We used to run run_viofs_service first and then reboot the vm,but now we run run_viofs_service after vm reboot.
There was a problem hiding this comment.
This patch indeed modify 'start virtiofs after reboot guest' issue, before we didn't consider it because most of windows guests don't need to reboot, but for win2012, it will reboot guest, but after reboot, there is no start virtiofs steps.
|
@YongxueHong Could you help review this patch? |
For some guests, need to restart os after updating drivers. And after os rebooted, need to start virtiofs service.
ID: 2156859
Signed-off-by: Xiaoling Gao xiagao@redhat.com